DESCRIPTION

CBQE-4036 : Automate testcases for GSI Replica Indexes

Change-Id: I4c1e3386cb6b49263c891d399f6e59a9058d3765


COMMENTS

author: Alissa Huang
date: 2017-04-16 11:22:38.699000000

Uploaded patch set 1.

-------------------------------------
author: Emely Wilson
date: 2017-04-16 11:36:53.207000000

Patch Set 1: Code-Review+1

-------------------------------------
author: Coby Mathis
date: 2017-04-16 12:23:52.621000000

Patch Set 1: Code-Review-1

(6 comments)

Line:64, pytests/2i/base_2i.py -> these parameters are specific to recovery tests. Please initialise them in gsi_replica_indexes.py

Line:3, pytests/2i/gsi_replica_indexes.py -> log is a singleton object. Please don't import it. Use it as follows:

import logging
log = logging.getLogger(__name__) 

It uses the same object throughout the test run

Line:6, pytests/2i/gsi_replica_indexes.py -> Thread is imported below from threading. So, these can be removed.

Line:11, pytests/2i/gsi_replica_indexes.py -> Please remove since it is not used anywhere.

Line:13, pytests/2i/gsi_replica_indexes.py -> Please remove since it is not used anywhere

Line:14, pytests/2i/gsi_replica_indexes.py -> Please remove since it is not used anywhere

-------------------------------------
author: Alissa Huang
date: 2017-04-17 05:27:30.258000000

MISMATCHED INLINE COMMENT
Line:64, pytests/2i/base_2i.py -> Done

-------------------------------------
author: Alissa Huang
date: 2017-04-17 05:27:30.258000000

MISMATCHED INLINE COMMENT
Line:3, pytests/2i/gsi_replica_indexes.py -> Done

-------------------------------------
author: Alissa Huang
date: 2017-04-17 05:27:30.258000000

MISMATCHED INLINE COMMENT
Line:6, pytests/2i/gsi_replica_indexes.py -> Done

-------------------------------------
author: Alissa Huang
date: 2017-04-17 05:27:30.258000000

MISMATCHED INLINE COMMENT
Line:11, pytests/2i/gsi_replica_indexes.py -> Done

-------------------------------------
author: Alissa Huang
date: 2017-04-17 05:27:30.258000000

MISMATCHED INLINE COMMENT
Line:13, pytests/2i/gsi_replica_indexes.py -> Done

-------------------------------------
author: Alissa Huang
date: 2017-04-17 05:27:30.258000000

MISMATCHED INLINE COMMENT
Line:14, pytests/2i/gsi_replica_indexes.py -> Done

-------------------------------------
