DESCRIPTION

CBQE-0:: remove python sdk as default option with testrunner on tasks.py

add python_sdk parameter and removed it as default option

Change-Id: Id63d1afcc0bb19baaea28e3275e8f8593bd611ff


COMMENTS

author: Quentin Ali
date: 2015-08-24 19:58:38.809000000

Patch Set 4: Commit message was updated

-------------------------------------
author: Hugo Blankenship
date: 2015-08-24 19:58:47.289000000

Patch Set 4:

Build Started http://factory.couchbase.com/job/testrunner-Jasmin Rangel-sherlock/5826/

-------------------------------------
author: Hugo Blankenship
date: 2015-08-24 19:59:08.251000000

Patch Set 4: Verified-1

Build Failed 

http://factory.couchbase.com/job/testrunner-Jasmin Rangel-sherlock/5826/ : FAILURE

-------------------------------------
author: Quentin Ali
date: 2015-08-24 19:59:19.565000000

Patch Set 4:

locally everything passed - simple.conf

summary so far suite regressions.regressiontest.RegressionTests , pass 2 , fail 0
summary so far suite rebalance.rebalancein.RebalanceInTests , pass 1 , fail 0
summary so far suite memcapable.WarmUpMemcachedTest , pass 1 , fail 0
summary so far suite view.createdeleteview.CreateDeleteViewTests , pass 1 , fail 0
summary so far suite view.viewquerytests.ViewQueryTests , pass 2 , fail 0
summary so far suite xdcr.uniXDCR.unidirectional , pass 2 , fail 0

-------------------------------------
author: Angelina Mayer
date: 2015-08-24 23:47:43.811000000

Patch Set 4:

(1 comment)

Line:39, lib/tasks/task.py -> I still don't understand how we are changing the default here. Isn't this a rewrite of the same if condition?

We probably need to change the testconstants.TESTRUNNER_CLIENT assignment(where we detect sdk installation and do testconstants.TESTRUNNER_CLIENT] = testconstants.PYTHON_SDK) .
At this point, it has already happened. 

What am I missing?

-------------------------------------
author: Quentin Ali
date: 2015-08-24 23:50:22.631000000

Patch Set 4:

(1 comment)

Line:39, lib/tasks/task.py -> By default there is no parameter. We can change this is in basetestcase.py. So it will default to the else condition.

-------------------------------------
author: Quentin Ali
date: 2015-08-25 02:35:53.792000000

Patch Set 5: Patch Set 4 was rebased

-------------------------------------
author: Tate Garrett
date: 2015-08-25 17:54:54.355000000

Change has been successfully cherry-picked as b502665ac485e01df27a4d8111a64aa9385a913b

-------------------------------------
