DESCRIPTION

CBQE:0 Support for tuning per-replication settings + new settings for Sherlock

Change-Id: Ib366dd1210c722aa5fcf295f8e3c79ef73d60d46


COMMENTS

author: Hugo Blankenship
date: 2014-11-24 19:38:22.925000000

Patch Set 4:

Build Started http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/3135/

-------------------------------------
author: Angelina Mayer
date: 2014-11-24 19:38:25.610000000

Patch Set 4: Verified+1

-------------------------------------
author: Hugo Blankenship
date: 2014-11-24 19:55:43.051000000

Patch Set 4: Verified+1

Build Successful 

http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/3135/ : SUCCESS

-------------------------------------
author: Fisher Vargas
date: 2014-11-25 08:33:51.473000000

Patch Set 4:

Aruna, Please reply to my comments so that I can understand the changes.

-------------------------------------
author: Angelina Mayer
date: 2014-11-26 19:16:54.304000000

Patch Set 4:

Sorry, left my comments in draft mode.

-------------------------------------
author: Fisher Vargas
date: 2014-11-27 10:52:28.590000000

Patch Set 4: Code-Review-1

(7 comments)

Line:425, pytests/xdcr/xdcrnewbasetests.py -> There are two initialization for rep_type.

Line:435, pytests/xdcr/xdcrnewbasetests.py -> Please create constant for each param name in class XDCR_PARAM instead string.

Line:453, pytests/xdcr/xdcrnewbasetests.py -> Use get() function in dictionary. self.__repl_spec.get(param, None)

Line:455, pytests/xdcr/xdcrnewbasetests.py -> If user will not pass these parameters as test param then " " will passed here as an argument, and will be set accordingly through rest API.

Line:456, pytests/xdcr/xdcrnewbasetests.py -> Use None instead " "

Line:486, pytests/xdcr/xdcrnewbasetests.py -> I will suggest to use **kwargs kind of argument passing here.

Line:487, pytests/xdcr/xdcrnewbasetests.py -> If user will not pass these parameters as test param then " " will passed here as an argument, and will be set accordingly through rest API. 

I will suggest to initialize all these parameters with its default value and overwrite as passed in test params rather than  " " as default one.

-------------------------------------
author: Angelina Mayer
date: 2014-12-02 01:39:22.932000000

Patch Set 4:

(7 comments)

Line:425, pytests/xdcr/xdcrnewbasetests.py -> Done

Line:435, pytests/xdcr/xdcrnewbasetests.py -> Done

Line:453, pytests/xdcr/xdcrnewbasetests.py -> Handled.

Line:455, pytests/xdcr/xdcrnewbasetests.py -> Handled

Line:456, pytests/xdcr/xdcrnewbasetests.py -> Handled

Line:486, pytests/xdcr/xdcrnewbasetests.py -> Handled.

Line:487, pytests/xdcr/xdcrnewbasetests.py -> Done

-------------------------------------
