DESCRIPTION

CBQE-0: upr is now default. Support for setting to tap

Change-Id: Ia444e8d2cf23a42c34107c826a264cc6005ab9bf


COMMENTS

author: Quentin Ali
date: 2014-05-27 21:34:21.484000000

Uploaded patch set 5.

-------------------------------------
author: Hugo Blankenship
date: 2014-05-27 21:34:30.107000000

Patch Set 5:

Build Started http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/1596/

-------------------------------------
author: Hugo Blankenship
date: 2014-05-27 22:00:00.305000000

Patch Set 5: Verified+1

Build Successful 

http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/1596/ : SUCCESS

-------------------------------------
author: Fisher Vargas
date: 2014-05-28 06:48:57.746000000

Patch Set 5: Code-Review-2

(6 comments)

Line:450, scripts/install.py -> 1. Change in help of install.py to use

upr = None | True | False | true | false | none


2. we can change like:

if "upr" not in params:
    upr = None
else:
   upr = eval(string.capitalize(params["upr"]))

Line:455, scripts/install.py -> same as above.

Line:997, lib/remote/remote_util.py -> if upr == False:
    output, error = self.execute_command("sed -i 's/END INIT INFO/END INIT INFO\\nexport COUCHBASE_REPL_TYPE={1}/'\/opt/{0}/etc/{0}_init.d".format(server_type, "tap"))

Rest of the case will be handled here automatically.

Line:999, lib/remote/remote_util.py -> this statement has no effect. by default is upr during installation.

Line:1002, lib/remote/remote_util.py -> it needs to be checked if this variable is used in previous versions too.

Line:1005, lib/remote/remote_util.py -> same comments as above.

-------------------------------------
author: Esperanza Cherry
date: 2014-05-28 09:26:18.320000000

Patch Set 5:

(1 comment)

Line:450, scripts/install.py -> Parag, you changed param on tap in basetestcase. better to use the same parameter in the tests and in install.py

-------------------------------------
