DESCRIPTION

CBQE-0: enhance failover and rebalance logic with fixes to data_analysis logic

Change-Id: I39e8b65521414b872ded92b71ebe8f93a3b25199


COMMENTS

author: Hugo Blankenship
date: 2014-04-25 02:26:49.269000000

Patch Set 11:

Build Started http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/1157/

-------------------------------------
author: Hugo Blankenship
date: 2014-04-25 02:52:18.781000000

Patch Set 11: Verified-1

Build Failed 

http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/1157/ : FAILURE

-------------------------------------
author: Esperanza Cherry
date: 2014-04-25 05:30:23.755000000

Patch Set 11: Code-Review-2

(18 comments)

Line:20, pytests/rebalance/rebalancein.py -> please add the test in conf file

Line:74, pytests/failover/failoverbasetests.py -> almost all base funcs has duplicates in rebalance_base.py

Line:28, pytests/rebalance/rebalanceinout.py -> please add test in conf file

Line:11, pytests/failover/failovertests.py -> never used?

Line:12, pytests/failover/failovertests.py -> we have self.log in basetestcase

Line:319, pytests/failover/failovertests.py -> iterations_to_try is used somewhere?

Line:357, pytests/failover/failovertests.py -> iterations_to_try is used somewhere?

Line:373, pytests/failover/failovertests.py -> iterations_to_try is used somewhere?

Line:386, pytests/failover/failovertests.py -> what is the purpose to create these files?

Line:388, pytests/failover/failovertests.py -> the data_path might be not default + doesn't work on windows

Line:147, pytests/analysis/clusterinfoanalysis.py -> data_path depends on node settings

Line:14, pytests/rebalance/rebalance_base.py -> we have ";" in configs https://github.com/couchbase/testrunner/blob/master/conf/py-newrebalance.conf#L47

Line:36, pytests/rebalance/rebalance_base.py -> almost all base funcs has duplicates in failoverbasetests.py

Line:128, pytests/rebalance/rebalance_base.py -> seems like logic=True should be before main iteration

Line:163, pytests/rebalance/rebalance_base.py -> the same

Line:264, lib/couchbase/data_analysis_helper.py -> here is not clear what kind of data in logs

Line:477, lib/couchbase/data_analysis_helper.py -> typo? createMapVBucket?

Line:6, pytests/rebalance/rebalanceout.py -> RestHelper is not used

-------------------------------------
