DESCRIPTION

CBQE-2182: added steps to collect __all_docs__ and data files
for Xdcr tests

Change-Id: Ic456b03ed5013c8d30a6114663f7ddf021d9e533


COMMENTS

author: Fisher Vargas
date: 2014-04-14 10:13:10.956000000

Uploaded patch set 7.

-------------------------------------
author: Esperanza Cherry
date: 2014-04-14 10:24:41.854000000

Patch Set 7:

cluster_run is a simple-test that is run on Hugo Blankenship.

-------------------------------------
author: Esperanza Cherry
date: 2014-04-14 10:36:26.531000000

Patch Set 7:

(2 comments)

Line:62, scripts/collect_data_files.py -> data_path=RestConnection(self.server).get_nodes_self().dataStorage.path

Line:161, pytests/xdcr/xdcrbasetests.py -> if test failed before verification we dump all data. that is not required. see solution http://review.couchbase.org/#/c/35670/5/pytests/xdcr/xdcrbasetests.py with tag '%%%'

-------------------------------------
author: Fisher Vargas
date: 2014-04-14 10:49:02.755000000

Patch Set 7:

(1 comment)

Line:62, scripts/collect_data_files.py -> It will not work.

-------------------------------------
author: Fisher Vargas
date: 2014-04-14 10:49:30.158000000

Patch Set 7:

what is solution, not to run this code in cluster-run?

-------------------------------------
author: Hugo Blankenship
date: 2014-04-14 11:26:51.987000000

Patch Set 7:

Build Started http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/1039/

-------------------------------------
author: Esperanza Cherry
date: 2014-04-14 11:27:06.538000000

Patch Set 7:

(1 comment)

Line:62, scripts/collect_data_files.py -> why?

-------------------------------------
author: Fisher Vargas
date: 2014-04-14 11:33:30.445000000

Patch Set 7:

(1 comment)

Line:62, scripts/collect_data_files.py -> Can you please check the Node class representation, there is ssd and hhd two storage path here. 

xxx@xxx.xxx

{code}
        if 'storage' in parsed:
            storage = parsed['storage']
            for key in storage:
                disk_storage_list = storage[key]
                for dict_parsed in disk_storage_list:
                    if 'path' in dict_parsed and 'state' in dict_parsed and 'quotaMb' in dict_parsed:
                        dataStorage = NodeDataStorage()
                        dataStorage.path = dict_parsed['path']
                        dataStorage.index_path = dict_parsed.get('index_path', '')
                        dataStorage.quotaMb = dict_parsed['quotaMb']
                        dataStorage.state = dict_parsed['state']
                        dataStorage.type = key
                        node.storage.append(dataStorage)
{code}

did you try this?

-------------------------------------
author: Esperanza Cherry
date: 2014-04-14 11:41:13.037000000

Patch Set 7:

(1 comment)

Line:62, scripts/collect_data_files.py -> I didn't try 
https://github.com/couchbase/testrunner/blob/master/pytests/backuptests.py#L37
it uses data_path = info.storage[0].get_data_path()
backup tests should be broken also?

it's better to fix common functionality then create the new one. it is my opinion

-------------------------------------
author: Hugo Blankenship
date: 2014-04-14 12:01:58.082000000

Patch Set 7: Verified-1

Build Failed 

http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/1039/ : FAILURE

-------------------------------------
