DESCRIPTION

CBQE-2195: fix is_cluster_rebalanced

Change-Id: I1c655768f4976504ae7164195f0a6684d5d1587e


COMMENTS

author: Esperanza Cherry
date: 2014-04-12 12:58:57.463000000

Uploaded patch set 2.

-------------------------------------
author: Hugo Blankenship
date: 2014-04-12 13:37:45.023000000

Patch Set 2:

Build Started http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/1022/

-------------------------------------
author: Hugo Blankenship
date: 2014-04-12 14:17:59.813000000

Patch Set 2: Verified-1

Build Failed 

http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/1022/ : FAILURE

-------------------------------------
author: Quentin Ali
date: 2014-04-12 18:47:12.353000000

Patch Set 2: Code-Review-2

Whether Rebalance is running or not, the fix returns same result

i.e. /diag/eval status on 10.6.2.144:8091: True content: false command: ns_cluster_membership:is_balanced()

1) CASE For rebalance not completed

91-9660192519
2014-04-12 11:36:51 | INFO | MainProcess | Cluster_Thread | [rest_client._rebalance_progress] rebalance percentage : 21.328125 %

2014-04-12 11:36:52 | INFO | MainProcess | MainThread | [rest_client.rebalance_reached] rebalance reached >20.7077205882% in 46.1671938896 seconds 

2014-04-12 11:36:52 | INFO | MainProcess | MainThread | [rest_client.diag_eval] /diag/eval status on 10.6.2.144:8091: True content: false command: ns_cluster_membership:is_balanced()

2) Rebalance Completed

2014-04-12 11:42:10 | INFO | MainProcess | Cluster_Thread | [rest_client.add_node] adding remote node @10.6.2.149:8091 to this xxx@xxx.xxx

2014-04-12 11:42:20 | INFO | MainProcess | MainThread | [rest_client.rebalance_reached] rebalance reached >100% in 2.98397397995 seconds 

2014-04-12 11:42:20 | INFO | MainProcess | MainThread | [rest_client.diag_eval] /diag/eval status on 10.6.2.144:8091: True content: false command: ns_cluster_membership:is_balanced()

-------------------------------------
author: Esperanza Cherry
date: 2014-04-12 21:25:29.944000000

Patch Set 2:

as I see you run rebalance without buckets.

2014-04-12 11:42:20 | INFO | MainProcess | MainThread | [rest_client.rebalance_reached] rebalance reached >100% in 2.98397397995 seconds
2014-04-12 11:42:20 | INFO | MainProcess | MainThread | [rest_client.diag_eval] /diag/eval status on 10.6.2.144:8091: True content: false command: ns_cluster_membership:is_balanced()

'rebalance reached >100% in 2.98397397995 seconds' doesn't mean that rebalance successful. 

could you provide your code and all test logs(please use https://friendpaste.com/) and check that rebalance complete successful when  you call is_cluster_rebalanced in second time

-------------------------------------
author: Quentin Ali
date: 2014-04-12 22:18:49.413000000

Patch Set 2: -Code-Review

I verified but adding a delay of 5 seconds to make sure the state of the system is consistent if actually it was rebalanced. So it does distinguish when it is not balanced vs it is balanced.

-------------------------------------
