DESCRIPTION

CBQE-2049: Add changes for fullEviction tests

Change-Id: I6ebb7220718e39cfb2e3cd2f0115f4246d1ba8f1


COMMENTS

author: Hugo Blankenship
date: 2014-02-19 22:01:49.683000000

Patch Set 1:

Build Started http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/559/

-------------------------------------
author: Amani Conrad
date: 2014-02-19 22:03:56.506000000

Patch Set 1:

With 3.0 the new param : evictionPolicy=fullEviction is enabled. This change adds this option to the basetests and related file changes.

-------------------------------------
author: Titus Ho
date: 2014-02-19 22:13:29.137000000

Patch Set 1: Code-Review-1

(3 comments)

thx Amani Conrad.  also to ensure compatibility with old tests, I suggest put new arg at end of method and assign default method as some tests still directly call cluster.create_default_bucket.

Line:1333, lib/membase/api/rest_client.py -> is this the default?  in params it's set to 'valueOnly'

Line:20, lib/couchbase/cluster.py -> suggest making this last argument and providing default value = '', or whatever the default is 'valueOnly' ?

Line:195, lib/couchbase/cluster.py -> same as async method.  having as 2nd arg will break several tests…

-------------------------------------
author: Amani Conrad
date: 2014-02-19 22:19:05.629000000

Patch Set 1:

Will do as the last argument.

However, the new param eviction_policy by default is assigned 'valueOnly' on the basetests.

self.eviction_policy=self.input.param("eviction_policy", 'valueOnly')

But I get your point of other tests, so will change this across the calls.

-------------------------------------
author: Hugo Blankenship
date: 2014-02-19 22:23:02.686000000

Patch Set 1: Verified-1

Build Failed 

http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/559/ : FAILURE

-------------------------------------
author: Amani Conrad
date: 2014-02-20 00:08:21.166000000

Abandoned

-------------------------------------
