DESCRIPTION

CBQE-0: refactoring Partition class in kv_store

Change-Id: I8e21c874baea5f86dbf6a906414d4226a3fbf69b


COMMENTS

author: Fisher Vargas
date: 2014-02-18 07:36:57.280000000

Uploaded patch set 4.

-------------------------------------
author: Fisher Vargas
date: 2014-02-18 07:38:03.607000000

Patch Set 4:

Andrei, I have removed locking from Partition as of now. Please review now.

-------------------------------------
author: Esperanza Cherry
date: 2014-02-18 08:08:07.931000000

Patch Set 4: Code-Review-1

(2 comments)

Line:134, lib/memcached/helper/kvstore.py -> self.__expire_key(key) returns nothing?

Line:150, lib/memcached/helper/kvstore.py -> sorry, I can't approve these changes. you change semantic of the method. what method I should use to check if item expired?

-------------------------------------
author: Fisher Vargas
date: 2014-02-18 09:46:47.598000000

Patch Set 5: Patch Set 4 was rebased

-------------------------------------
author: Hugo Blankenship
date: 2014-02-18 12:38:02.370000000

Patch Set 4:

Build Started http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/525/

-------------------------------------
author: Hugo Blankenship
date: 2014-02-18 13:02:52.162000000

Patch Set 4: Verified+1

Build Successful 

http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/525/ : SUCCESS

-------------------------------------
