DESCRIPTION

CBQE-0: for some tasks we need to set_exception when task result is false

I guess that we can lose some failures when we set self.set_result(False) without
self.set_exception

very often we are just waiting for that task is completed, but if it completed with status false(=error) we do not check the status of the task

Change-Id: I900c25dfaf0dc322661ca294781db2499c4abe41


COMMENTS

author: Hugo Blankenship
date: 2014-01-26 15:19:24.245000000

Patch Set 1:

Build Started http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/226/

-------------------------------------
author: Hugo Blankenship
date: 2014-01-26 15:42:26.008000000

Patch Set 1: Verified-1

Build Failed 

http://factory.couchbase.com/job/testrunner-Jasmin Rangel-master/226/ : FAILURE

-------------------------------------
author: Trevor Santana
date: 2014-01-27 09:23:02.107000000

Patch Set 1: Code-Review+2

-------------------------------------
author: Titus Ho
date: 2014-01-27 15:37:08.293000000

Patch Set 1: Code-Review-1

(2 comments)

Line:1910, lib/tasks/task.py -> Consider using generic exception class
self.set_exception(Exception("progress….")).  There isn't any task that sets this to a string…does this work?


Recommended form of handling would b adding a custom exception to lib/membase/api/exceptions.py.

Wrap these calls inside of a try block.

raise Custom Exception.

catch exception then:

self.set_exception(e)

Line:2713, lib/tasks/task.py -> Shouldn't this be:
self.set_exception(e)

The BucketFlushFailed exception being caught should contain this message

-------------------------------------
author: Titus Ho
date: 2017-10-10 01:12:56.916000000

Abandoned

-------------------------------------
