DESCRIPTION

CBQE-0: some fixes in plotter.py

Change-Id: Idba8a78846feded7df6280b4d2549b1c6611816e


COMMENTS

author: Hugo Blankenship
date: 2013-07-17 15:19:14.498000000

Patch Set 1:

Build Started http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/6584/ 

-------------------------------------
author: Hugo Blankenship
date: 2013-07-17 15:21:42.483000000

Patch Set 1:

Build Failed 

http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/6584/ : FAILURE

-------------------------------------
author: Titus Ho
date: 2013-07-17 17:47:03.501000000

Patch Set 1: Looks good to me, approved



-------------------------------------
author: Roland Charles
date: 2013-07-19 19:02:33.604000000

Patch Set 1: (2 inline comments)



Line:55, pysystests/tools/plotter.py -> Will this REST call download the pdf report?

Line:126, pysystests/tools/plotter.py -> I don't think ns_server_db string contains ":"? What's this for?

-------------------------------------
author: Roland Charles
date: 2013-07-19 19:11:01.829000000

Patch Set 1: (1 inline comment)



Line:126, pysystests/tools/plotter.py -> Sorry Andrei, I got the point of this catch. When user store 127.0.0.1:9000 in testcfg.py for CLUSTER_IP, ns_server_db will be something like ns_serverdefaultdefault127001:9000. That's a great bug fix

-------------------------------------
author: Roland Charles
date: 2013-07-19 19:15:33.187000000

Patch Set 1: Looks good to me, but someone else must approve



-------------------------------------
author: Esperanza Cherry
date: 2013-07-22 13:51:33.168000000

Patch Set 1:

(1 comment)

Line:55, pysystests/tools/plotter.py -> [19:54:12] Titus Ho: wow, missed this - thx
[19:55:08] Titus Ho: interesting… did the snapshot url change to /cbmonitor/pdf ?
[19:55:55] Esperanza Cherry: are you saying about http://review.couchbase.org/#/c/27485/1/pysystests/tools/plotter.py
[19:56:02] Titus Ho: yah
[19:56:38] Esperanza Cherry: we can't get pdf report if we did't generate it before
[19:57:02] Esperanza Cherry: manually or  = requests.post('http://%s:8000/cbmonitor/pdf/' % cfg.SERIESLY_IP, data={'snapshot':snapshot_n
[19:57:11] Titus Ho: right! thought that was me doing something wrong

so, post  command has the same result as when we press "PDF" button.

-------------------------------------
author: Titus Ho
date: 2013-07-22 15:56:59.772000000

Patch Set 1:

(1 comment)

Line:55, pysystests/tools/plotter.py -> i'm wondering now if its possible that cbmonitor has 2 similar api's?  for instance Roland Charles is doing a GET with the snapshot name in the path, but  this change does a POST with snapshot name in the data payload.

probably we should use whichever one is used by the ui- i'm assuming the POST here

-------------------------------------
author: Roland Charles
date: 2013-07-22 21:07:33.287000000

Patch Set 1:

(1 comment)

Line:55, pysystests/tools/plotter.py -> Yeah, Andrei I see your point. That's a correct REST call. POST request "press" the pdf bottom to generate the report. And then we can download it. But report generation takes a while after we press the pdf bottom. Do we consider it already?

-------------------------------------
author: Esperanza Cherry
date: 2013-07-22 21:18:27.387000000

Patch Set 1:

(1 comment)

Line:55, pysystests/tools/plotter.py -> Yes, it waits until the report is generated.Only then we get a responce

-------------------------------------
author: Esperanza Cherry
date: 2013-07-22 21:27:37.929000000

Patch Set 1: Verified+1

-------------------------------------
author: Tate Garrett
date: 2013-07-22 21:27:43.494000000

The change could not be merged due to a path conflict.

Please rebase the change locally and upload the rebased commit for review.

-------------------------------------
author: Roland Charles
date: 2013-07-22 22:21:04.705000000

Patch Set 2: Patch Set 1 was rebased

-------------------------------------
