DESCRIPTION

CBQE-433: Fix kvstore expired items on kvstore.py

Change-Id: I5b91959f4869c8853b540fd1764898b67b289578


COMMENTS

author: Kenny Maynard
date: 2012-08-03 21:12:20.308000000

Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)



Line:139, lib/memcached/helper/kvstore.py -> if self._expired(key):

-------------------------------------
author: Kenny Maynard
date: 2012-08-03 21:14:19.512000000

Patch Set 1: (1 inline comment)



Line:137, lib/memcached/helper/kvstore.py -> Also, please make this length = 0 and then count up if a key is not expired. I'm pretty sure calling length on a dictionary causes the entire thing to be traversed. If you count up you will only traverse the dictionary once.

-------------------------------------
author: Amani Conrad
date: 2012-08-03 21:38:18.005000000

Patch Set 1: (2 inline comments)



Line:137, lib/memcached/helper/kvstore.py -> Done

Line:139, lib/memcached/helper/kvstore.py -> Done

-------------------------------------
author: Hugo Blankenship
date: 2012-08-03 22:05:11.343000000

Patch Set 1:

Build Started http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/2217/ 

-------------------------------------
author: Hugo Blankenship
date: 2012-08-03 22:22:14.177000000

Patch Set 1:

Build Successful 

http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/2217/ : SUCCESS

-------------------------------------
