DESCRIPTION

fix_for_wait_for_memcached

Change-Id: I4048c58cd8d1ee6a58845f2fda17b57929bc9981


COMMENTS

author: Emerson Nolan
date: 2012-07-16 08:08:06.532000000

Uploaded patch set 5.

-------------------------------------
author: Ayla Reynolds
date: 2012-07-16 08:08:12.163000000

Patch Set 5:

Automatically re-added by Roselyn Villegas trivial rebase detection script.

-------------------------------------
author: Reid Stokes
date: 2012-07-16 08:08:13.314000000

Patch Set 5:

Automatically re-added by Roselyn Villegas trivial rebase detection script.

-------------------------------------
author: Esperanza Cherry
date: 2012-07-16 08:08:14.498000000

Patch Set 5:

Automatically re-added by Roselyn Villegas trivial rebase detection script.

-------------------------------------
author: Hugo Blankenship
date: 2012-07-16 08:12:35.906000000

Patch Set 5:

Build Started http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1682/ 

-------------------------------------
author: Hugo Blankenship
date: 2012-07-16 08:19:28.423000000

Patch Set 5: Verified

Build Successful 

http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1682/ : SUCCESS

-------------------------------------
author: Ayla Reynolds
date: 2012-07-16 11:46:43.362000000

Patch Set 5:

It still doesn't work. When I run a spatial test on clean checkout with:

./testrunner -i b/resources/dev-4-nodes.ini  -t spatialinfotests.SpatialInfoTests.test_spatial_info

I get:

[2012-07-16 13:45:36,141] - [bucket_helper:214] ERROR - Memcached error #7 'Not my vbucket':  That's not my bucket. for vbucket :86 to mc 192.168.178.26:12003
ERROR

======================================================================
ERROR: test_spatial_info (spatialinfotests.SpatialInfoTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "pytests/spatialinfotests.py", line 12, in setUp
    self.helper.setup_cluster()
  File "lib/membase/helper/spatial_helper.py", line 53, in setup_cluster
    self._create_default_bucket()
  File "lib/membase/helper/spatial_helper.py", line 242, in _create_default_bucket
    self.bucket)
  File "lib/membase/helper/bucket_helper.py", line 259, in wait_for_memcached
    bucket, timeout_in_seconds)
  File "lib/membase/helper/bucket_helper.py", line 212, in wait_for_vbuckets_ready_state
    (a, b, c) = client.get_vbucket_state(i)
  File "lib/mc_bin_client.py", line 325, in get_vbucket_state
    str(vbucket), '')
  File "lib/mc_bin_client.py", line 127, in _doCmd
    self._sendCmd(cmd, key, val, opaque, extraHeader, cas)
  File "lib/mc_bin_client.py", line 67, in _sendCmd
    vbucketId=self.vbucketId)
  File "lib/mc_bin_client.py", line 75, in _sendMsg
    _, w, _ = select.select([], [self.s], [], self.timeout)
  File "/usr/lib/python2.7/socket.py", line 224, in meth
    return getattr(self._sock,name)(*args)
  File "/usr/lib/python2.7/socket.py", line 170, in _dummy
    raise error(EBADF, 'Bad file descriptor')
error: [Errno 9] Bad file descriptor

----------------------------------------------------------------------
Ran 1 test in 29.540s

FAILED (errors=1)
summary so far suite spatialinfotests.SpatialInfoTests , pass 0 , fail 1

-------------------------------------
author: Porter Oconnor
date: 2012-07-16 12:04:09.108000000

Patch Set 5: I would prefer that you didn't submit this

Sorry for the intrusion, but I can't notice the commit message is nearly meaningless.

It should explain exactly what is being fixed, why it was not working before and what does this change does exactly to fix the issue.

See good guide notes about commit messages:
http://ablogaboutcode.com/2011/03/23/proper-git-commit-messages-and-an-elegant-git-history/

-------------------------------------
author: Porter Oconnor
date: 2012-07-16 12:06:51.953000000

Patch Set 5:

Also, see our own good commit messages guideline:

http://www.couchbase.com/wiki/display/couchbase/Contributing+Changes#ContributingChanges-Links

-------------------------------------
