DESCRIPTION

fixed wait_for_memcached_helper

Change-Id: I9b2126c3c7e3f8f1a5cf772890d443397baa2974


COMMENTS

author: Reid Stokes
date: 2012-07-11 01:50:35.824000000

Patch Set 1: Do not submit

(2 inline comments)

There should be no whitespaces..

Line:5, pytests/createbuckettests.py -> wwhy are these needed?

Line:33, pytests/createbuckettests.py -> no whitespaces...

-------------------------------------
author: Reid Stokes
date: 2012-07-11 02:31:19.941000000

Patch Set 1: (8 inline comments)



Line:203, lib/membase/helper/bucket_helper.py -> space after comma

Line:205, lib/membase/helper/bucket_helper.py -> shouldnt there be else case here..?

Line:211, lib/membase/helper/bucket_helper.py -> client.close?

Line:234, lib/membase/helper/bucket_helper.py -> no print..

Line:248, lib/membase/helper/bucket_helper.py -> space after comma

Line:250, lib/membase/helper/bucket_helper.py -> swap the above 2 stmts

vbuckets  = rest.get_vbuckets(bucket)
vbucket_count = len(vbuckets)

Line:257, lib/membase/helper/bucket_helper.py -> how do u know here.. that all vbucketId are covered...

keys can collide in this case... doign uuid.uuid4() can return you 2 or more keys mapping to the same vbucketId.

Line:261, lib/membase/helper/bucket_helper.py -> no print.
remove these extra comments

-------------------------------------
author: Hugo Blankenship
date: 2012-07-12 08:37:33.520000000

Patch Set 1:

Build Started http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1537/ 

-------------------------------------
author: Hugo Blankenship
date: 2012-07-12 08:51:10.180000000

Patch Set 1: Verified

Build Successful 

http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1537/ : SUCCESS

-------------------------------------
author: Reid Stokes
date: 2012-07-23 18:47:10.870000000

Patch Set 1:

Can we abandon this?

-------------------------------------
author: Reid Stokes
date: 2012-07-25 18:26:53.106000000

Patch Set 1: Abandoned

-------------------------------------
