DESCRIPTION

Adding xdcr base tests
(to be addressed : memcached error exception)
Change-Id: I00998ac68395bede407976dbb6541127bbe4f1d8


COMMENTS

author: Amani Conrad
date: 2012-07-16 15:10:09.486000000

Uploaded patch set 6.

-------------------------------------
author: Hugo Blankenship
date: 2012-07-16 15:15:16.389000000

Patch Set 6:

Build Started http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1684/ 

-------------------------------------
author: Hugo Blankenship
date: 2012-07-16 15:23:48.069000000

Patch Set 6: Verified

Build Successful 

http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1684/ : SUCCESS

-------------------------------------
author: Amani Conrad
date: 2012-07-16 16:39:45.451000000

Patch Set 6: (6 inline comments)



Line:5, conf/py-xdcr-bidirectional.conf -> Test and add for items =100000

Line:33, pytests/xdcr-mod/bidirectional-xdcr.py -> Comments change to "python stds" desc on coding stds

Line:546, lib/tasks/task.py -> Rename as VerifyRevIdTask

Line:570, lib/tasks/task.py -> rename variables to more logical names

Line:575, lib/tasks/task.py -> Print what "key" was mismatched. Add check for upto 10 mismatched keys and then exit with exception.

Line:577, lib/tasks/task.py -> check -error condition - this is not correct

-------------------------------------
author: Amani Conrad
date: 2012-07-16 17:57:10.504000000

Patch Set 6: (1 inline comment)



Line:583, lib/tasks/task.py -> Not needed here.

-------------------------------------
author: Reid Stokes
date: 2012-07-16 18:31:43.693000000

Patch Set 6: (14 inline comments)



Line:5, pytests/xdcr-mod/xdcrbasetests.py -> unused..

Line:86, pytests/xdcr-mod/xdcrbasetests.py -> can we change the param name.. olst is not very intuitive

Line:172, pytests/xdcr-mod/xdcrbasetests.py -> task is not used anywhere

Line:174, pytests/xdcr-mod/xdcrbasetests.py -> is this self.bucket_tasks?

Line:269, pytests/xdcr-mod/xdcrbasetests.py -> src_cluster_name not used

Line:278, pytests/xdcr-mod/xdcrbasetests.py -> no hardcoding of bucket name..

Line:304, pytests/xdcr-mod/xdcrbasetests.py -> Do you think we should also wait for these to be zero. 
idle|ack_log_size

Line:318, pytests/xdcr-mod/xdcrbasetests.py -> self._timeout

Line:320, pytests/xdcr-mod/xdcrbasetests.py -> do you have logger object here.. use that instead..

Line:325, pytests/xdcr-mod/xdcrbasetests.py -> both num_try?

Line:338, pytests/xdcr-mod/xdcrbasetests.py -> This if..else seems redundant..

available_replicas is both the times equal to len(servers)-1.. 

its better to use a not...

Line:360, pytests/xdcr-mod/xdcrbasetests.py -> bucket.. and not default

Line:82, pytests/xdcr-mod/unidirectional-xdcr.py -> tasks is anyways defined empty

Line:86, pytests/xdcr-mod/unidirectional-xdcr.py -> Why cant we just always do tasks.extend..

-------------------------------------
