DESCRIPTION

CBQE-282: cases rebalance in/out with view queries

Change-Id: I7f1cb9638ac8d5f73e4fe593150d6299d7efff1b


COMMENTS

author: Esperanza Cherry
date: 2012-06-27 02:23:57.512000000

Uploaded patch set 2.

-------------------------------------
author: Hugo Blankenship
date: 2012-06-27 02:34:05.344000000

Patch Set 2:

Build Started http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1211/ 

-------------------------------------
author: Hugo Blankenship
date: 2012-06-27 02:45:10.709000000

Patch Set 2: Verified

Build Successful 

http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1211/ : SUCCESS

-------------------------------------
author: Zackery Barr
date: 2012-06-27 05:09:19.926000000

Patch Set 2: (6 inline comments)

overall looks good. a few comment .

Line:99, pytests/rebalance/rebalancein.py -> please remove time.sleep here

Line:103, pytests/rebalance/rebalancein.py -> we need to support multiple buckets

Line:107, pytests/rebalance/rebalancein.py -> will this fail if rebalance fails or the test will ignore the error

Line:15, pytests/rebalance/rebalance_base.py -> can we choose another map functional . doc_id , null is not a valid use case

Line:27, pytests/rebalance/rebalance_base.py -> self.servers[0] won't work for swap rebalance tests.

Line:43, pytests/rebalance/rebalance_base.py -> reformat this code ( python coding guideline )

-------------------------------------
author: Trevor Santana
date: 2012-06-27 05:14:46.390000000

Patch Set 2: Looks good to me, but someone else must approve

(7 inline comments)



Line:102, pytests/rebalance/rebalancein.py -> xrange(num_views)

Line:109, pytests/rebalance/rebalancein.py -> the same as above

Line:37, pytests/rebalance/rebalance_base.py -> why do you have double curls?

Line:41, pytests/rebalance/rebalance_base.py -> what prefix variable mean? it's not used

Line:42, pytests/rebalance/rebalance_base.py -> when you will use this variable? it mentioned only in return statement

Line:45, pytests/rebalance/rebalance_base.py -> xrange(count)

Line:105, pytests/rebalance/rebalanceout.py -> the same

-------------------------------------
author: Esperanza Cherry
date: 2012-06-27 06:40:20.982000000

Patch Set 2: (2 inline comments)



Line:99, pytests/rebalance/rebalancein.py -> on the latest build requests are successful in the beginning of the rebalance, but do not pass at the end of. still remove it?

Line:107, pytests/rebalance/rebalancein.py -> test will faill

-------------------------------------
author: Esperanza Cherry
date: 2012-06-27 08:16:38.496000000

Patch Set 2: (3 inline comments)



Line:27, pytests/rebalance/rebalance_base.py -> it's a setup, here can't be swap

Line:37, pytests/rebalance/rebalance_base.py -> template is used in string formatting, double braces is required to get them in the results

Line:42, pytests/rebalance/rebalance_base.py -> poorly readable

-------------------------------------
author: Tate Garrett
date: 2012-07-02 16:47:01.172000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
