DESCRIPTION

CBQE-175 Added create view test cases after refactoring

Change-Id: I1207dd9331b1de63c8514512c5a35762ac6733c0


COMMENTS

author: Trey Garner
date: 2012-06-20 19:11:37.052000000

Uploaded patch set 2.

-------------------------------------
author: Hugo Blankenship
date: 2012-06-20 19:21:00.213000000

Patch Set 2:

Build Started http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1076/ 

-------------------------------------
author: Hugo Blankenship
date: 2012-06-20 19:30:56.305000000

Patch Set 2: Verified

Build Successful 

http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/1076/ : SUCCESS

-------------------------------------
author: Titus Ho
date: 2012-06-20 20:32:58.463000000

Patch Set 2: I would prefer that you didn't submit this

(6 inline comments)

Looking good, some comments inline.

Line:110, pytests/view/createviewtests.py -> Passed only if DesignDocCreationException is thrown

Line:125, pytests/view/createviewtests.py -> how about …_same_name_parallel?  since we aren't making threads anymore

Line:139, pytests/view/createviewtests.py -> given name of test, by default this variable should be > 1

Line:141, pytests/view/createviewtests.py -> no need to init with empty arrays since assignments are on next line in the same scope

Line:162, pytests/view/createviewtests.py -> So there's not really an api equivalent to adding a view to a deleted design doc.  
Reason being every time a view is added, ddoc info is also required in the request to the server.  If the ddoc doesn't exist in the request itself cannot be made.

Line:168, pytests/view/createviewtests.py -> I can see this being 2 separate cases that need to do queries:
* complicated map function should allow you do to a basic query without throwing QueryViewException

* not_compiled map function should throw QueryViewException when view is queried

-------------------------------------
author: Esperanza Cherry
date: 2012-06-20 21:58:15.187000000

Patch Set 2: (1 inline comment)



Line:27, pytests/view/createviewtests.py -> default_invalid_view_name_list & long_view_nam is used in one test func, it's not needed to add in setUp

-------------------------------------
author: Esperanza Cherry
date: 2012-06-20 22:14:35.513000000

Patch Set 2: (4 inline comments)



Line:44, pytests/view/createviewtests.py -> can without esle + add comment for the func

Line:94, pytests/view/createviewtests.py -> tearDown UP, after setup

Line:120, pytests/view/createviewtests.py -> for loop better?

Line:130, pytests/view/createviewtests.py -> loop?

-------------------------------------
