DESCRIPTION

CBD-164: catch all exceptions instead EOFError.

For longer warm-up phase, connection will be reset,\
rasing other exceptions rather than broken pipe.

Change-Id: I3bd25dc2a0f7ec1f7741352ba654bcdca7664b4a


COMMENTS

author: Hugo Blankenship
date: 2012-05-19 07:55:00.071000000

Patch Set 1:

Build Started http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/342/ 

-------------------------------------
author: Hugo Blankenship
date: 2012-05-19 08:05:09.489000000

Patch Set 1: Verified

Build Successful 

http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/342/ : SUCCESS

-------------------------------------
author: Alex Mcmahon
date: 2012-05-19 16:26:44.430000000

Patch Set 1: (1 inline comment)



Line:354, lib/membase/performance/stats.py -> What other exceptions are you trying to catch?

-------------------------------------
author: Daniel Blair
date: 2012-05-19 17:39:28.788000000

Patch Set 1: (1 inline comment)



Line:354, lib/membase/performance/stats.py -> urlerror. and there might be other errors. plz do a quick review. I really need this to be checked in

-------------------------------------
author: Daniel Blair
date: 2012-05-19 17:47:41.216000000

Patch Set 1: Verified; Looks good to me, approved

submitted this change. this will catch all exceptions including env ones.(ioerror in this case) if any objections, will revert later

-------------------------------------
author: Daniel Blair
date: 2012-05-19 17:47:42.259000000

Change has been successfully cherry-picked as 3264e7b354ce27c06ad1577ae2e31ee0d5943e2d.

-------------------------------------
author: Alex Mcmahon
date: 2012-05-20 07:59:59.098000000

Patch Set 1: (1 inline comment)



Line:354, lib/membase/performance/stats.py -> That's absolutely fine. Sorry, didn't know that it's so critical for you.

-------------------------------------
author: Zackery Barr
date: 2012-05-20 17:40:59.586000000

Patch Set 1:

adding Karan to the reviewer since there is a change in rebalance_helper

-------------------------------------
author: Zackery Barr
date: 2012-05-20 17:41:39.544000000

Patch Set 1:

figured its too late for that.

Ronnie/Pavel,

can you please add karan or Amani Conrad when making changes to helper methods ?

-------------------------------------
author: Alex Mcmahon
date: 2012-05-20 18:09:52.486000000

Patch Set 1:

Ok, it makes sense.

-------------------------------------
author: Daniel Blair
date: 2012-05-20 19:15:48.057000000

Patch Set 1: (1 inline comment)

@Zackery Barr. yes will do

Line:354, lib/membase/performance/stats.py -> No problem.pavel

-------------------------------------
