DESCRIPTION

Enable and add Warmup Tests

Change-Id: I253ecac4d1ecd75791f894014ea7b6f49f998727


COMMENTS

author: Amani Conrad
date: 2012-05-10 06:10:51.915000000

Uploaded patch set 4.

-------------------------------------
author: Hugo Blankenship
date: 2012-05-10 06:14:52.555000000

Patch Set 4:

Build Started http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/114/ 

-------------------------------------
author: Amani Conrad
date: 2012-05-10 06:16:39.107000000

Patch Set 4:

Edits done, runs clean on tested VMs.

-------------------------------------
author: Hugo Blankenship
date: 2012-05-10 06:21:25.714000000

Patch Set 4: Verified

Build Successful 

http://qa.hq.northscale.net/job/testrunner-Jasmin Rangel-master/114/ : SUCCESS

-------------------------------------
author: Reid Stokes
date: 2012-05-10 08:07:10.659000000

Patch Set 4: (5 inline comments)

Finally .. warmuptests .. 
small comments here and there..

Line:160, pytests/warmupcluster.py -> Why do we want to vary wait time?

Line:178, pytests/warmupcluster.py -> log.error

Line:180, pytests/warmupcluster.py -> I would suggest you use.. while else 

while <condition>

else
self.fail...

Line:182, pytests/warmupcluster.py -> You seem to be varying wait_time
add {2}.format(wait_time)

Line:187, pytests/warmupcluster.py -> in_start is redundant
u can reuse start..

-------------------------------------
author: Reid Stokes
date: 2012-05-10 08:10:07.201000000

Patch Set 4: (2 inline comments)



Line:160, pytests/warmupcluster.py -> ohh.. i see. this is fine..

Line:171, pytests/warmupcluster.py -> Can we print out.. server.ip.. somewhere .. in case of success..

-------------------------------------
author: Amani Conrad
date: 2012-05-10 19:31:06.222000000

Patch Set 4: (5 inline comments)

edited

Line:160, pytests/warmupcluster.py -> ok

Line:171, pytests/warmupcluster.py -> Done

Line:180, pytests/warmupcluster.py -> Done

Line:182, pytests/warmupcluster.py -> Done

Line:187, pytests/warmupcluster.py -> Done

-------------------------------------
