DESCRIPTION

add enable, disable firewall, add switch -i in sudo and update test cases using this new methods

Change-Id: I7e5d451403744b1afefa5f22086711c5138bde6b


COMMENTS

author: Frederick Booker
date: 2012-04-23 18:50:22.644000000

Uploaded patch set 4.

-------------------------------------
author: Frederick Booker
date: 2012-04-23 18:51:25.685000000

Patch Set 4: Verified



-------------------------------------
author: Reid Stokes
date: 2012-04-23 19:02:01.529000000

Patch Set 4: I would prefer that you didn't submit this

(3 inline comments)

Reduce the code duplication

Line:27, pytests/autofailovertests.py -> Create one method for both 
common_setup and common_teardown(

Line:23, pytests/failovertests.py -> Create this as separate method.

for server in servers:
...
.....
shell.disconnect()...

Line:49, pytests/failovertests.py -> Same as above

-------------------------------------
author: Ayden Rivas
date: 2012-04-23 19:12:58.679000000

Patch Set 4: (1 inline comment)



Line:1023, lib/remote/remote_util.py -> is there a reason you are adding this? sudo -i breaks on ubuntu 10.04

-------------------------------------
author: Frederick Booker
date: 2012-04-23 21:20:18.510000000

Patch Set 4: (1 inline comment)



Line:1023, lib/remote/remote_util.py -> we need this -i for sudo work in centos to turn on or off firewall

-------------------------------------
author: Ayden Rivas
date: 2012-04-23 21:28:00.446000000

Patch Set 4: (1 inline comment)



Line:1023, lib/remote/remote_util.py -> what if we add "PATH=$PATH:/usr/sbin:/sbin" ?

-------------------------------------
