DESCRIPTION

ePerf: Use system call instead of popen.

Observed that python's popen hangs when parent
process is trying to gather large outputs from
the child process
http://stackoverflow.com/questions/2151640/pythons-subprocess-popen-object-hangs-gathering-child-output-when-child-process

Change-Id: I1c36933ce375d7e538abae1b80330fd9dbd59e19


COMMENTS

author: Reid Stokes
date: 2012-01-06 19:56:15.867000000

Patch Set 1: Verified



-------------------------------------
author: Reid Stokes
date: 2012-01-06 19:58:53.878000000

Patch Set 1:

This seems more appropriate:- 
http://stackoverflow.com/questions/2061420/subprocess-popen-curl-binary-data

Earlier we were using os.popen(<command>) , instead of 
os.popen(<command>, shell=TRUE) (recommended)

-------------------------------------
author: Reid Stokes
date: 2012-01-06 20:06:27.018000000

Patch Set 1:

http://bugs.python.org/issue1336
http://bugs.python.org/issue12786

-------------------------------------
author: Zackery Barr
date: 2012-01-06 20:08:15.829000000

Patch Set 1:

looks good to me but why not using rest_client to get this info ?

-------------------------------------
author: Reid Stokes
date: 2012-01-06 20:10:40.617000000

Patch Set 1:

We are dumping the whole ns_server_stats into a file, which is already a dict when downloaded from ns_server.

-------------------------------------
author: Zackery Barr
date: 2012-01-06 20:11:23.866000000

Patch Set 1: Verified; Looks good to me, approved



-------------------------------------
author: Reid Stokes
date: 2012-01-06 20:11:39.083000000

Change has been successfully cherry-picked as 508a16047725bb53d2bdc2b8c19836930868f962.

-------------------------------------
author: Zackery Barr
date: 2012-01-06 20:12:02.513000000

Patch Set 1:

does curl has a timeout option ?

-------------------------------------
