DESCRIPTION

Added bucket monitor with response handler.

This adds a Bucket monitor with a response handler based on the netty
framework to read bucket's streaming channel. It passes the received
configuration to registered observers.

Change-Id: I92472a89f15b9fdbe9725f8a9a4abb2d645a591c


COMMENTS

author: Andreas Short
date: 2011-06-03 19:32:50.190000000

Uploaded patch set 2.

-------------------------------------
author: Asher Vang
date: 2011-06-03 19:32:59.502000000

Patch Set 2: Looks good to me, but someone else must approve

Automatically re-added by Gerrit trivial rebase detection script.

-------------------------------------
author: Jakob Lozano
date: 2011-06-03 19:52:27.661000000

Patch Set 2: (6 inline comments)



Line:22, src/main/java/net/spy/memcached/vbucket/BucketMonitor.java -> Move this import with the rest of the org.jboss.

Line:94, src/main/java/net/spy/memcached/vbucket/BucketMonitor.java -> Getting a logger may be slow, suggest getting it once and keeping a local copy.

Line:19, src/main/java/net/spy/memcached/vbucket/BucketUpdateResponseHandler.java -> Use spymemcached's logger infrastructure.

Line:36, src/main/java/net/spy/memcached/vbucket/BucketUpdateResponseHandler.java -> Use StringBuilder as StringBuffer has synchronized methods (yuck :) )  Or if you do mean StringBuffer for that reason, then document it.

Line:111, src/main/java/net/spy/memcached/vbucket/BucketUpdateResponseHandler.java -> Remove empty lines.

Line:19, src/main/java/net/spy/memcached/vbucket/BucketMonitorPipelineFactory.java -> No need for final here.

-------------------------------------
