DESCRIPTION

First iteration of systemtap gui app cleanup.

* do not use deprecated stuff
* drop excessive logging
* formatting 
* drop commented code

The app starts in an equally broken form as prior this patch, aka the
initial perspective is just empty.

Change-Id: Ie8555eb705a2a5527496cbe7b6d7998abc2e0c9c


COMMENTS

author: Brenden Conley
date: 2013-01-28 14:35:52.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1184/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-28 14:47:40.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1184/ : SUCCESS

-------------------------------------
author: Kamila Nguyen
date: 2013-01-28 15:40:05.000000000

Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

Two small changes. Otherwise looks good to me.

Line:89, systemtap/org.eclipse.linuxtools.systemtap.ui.systemtapgui/src/org/eclipse/linuxtools/systemtap/ui/systemtapgui/preferences/EnvironmentVariablesPreferencePage.java -> Could you add braces {} to the for loop.

Line:102, systemtap/org.eclipse.linuxtools.systemtap.ui.systemtapgui/src/org/eclipse/linuxtools/systemtap/ui/systemtapgui/preferences/EnvironmentVariablesPreferencePage.java -> braces here too would be great.

-------------------------------------
author: Octavio Lucero
date: 2013-01-28 15:45:39.000000000

Patch Set 1: (1 inline comment)



Line:131, systemtap/org.eclipse.linuxtools.systemtap.ui.systemtapgui/src/org/eclipse/linuxtools/systemtap/ui/systemtapgui/preferences/EnvironmentVariablesPreferencePage.java -> One mores set of braces missing here.

-------------------------------------
