DESCRIPTION

[LTTng] Show PIDs in events table

Change-Id: I6236f8dd0139413e14ac5f7c0efae5f454011248
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2013-01-25 19:04:03.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-01-25 19:15:32.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1166/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-25 19:28:43.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1166/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-01-28 20:17:44.000000000

Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

Cool end result, but before we merge a final version, we should:

* Fix the fact that it's hard to have more than 5 columns
* Have PID and process name in separate columns. Kind of goes with the previous point.

Line:1, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/viewers/events/Lttng2KernelEventsTable.java -> Missing copyright headur

Line:21, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/viewers/events/Lttng2KernelEventsTable.java -> "private static final" plz :P

-------------------------------------
author: Luciana Barry
date: 2013-01-29 22:40:40.000000000

Patch Set 2: (2 inline comments)



Line:10, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/viewers/events/Messages.java -> tabs!

Line:25, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/viewers/events/Lttng2KernelEventsTable.java -> Would be clearer if declared in the same order as the array

-------------------------------------
author: Ivy Mitchell
date: 2013-04-10 14:15:38.000000000

Patch Set 2: Abandoned

Too old!

-------------------------------------
