DESCRIPTION

Fix stop enablement bug

Remove unused code.
Added missing //$NON-NLS-1$.
Remove trailing whitespace.

Change-Id: I7556b6a5cf540ff392b40e1329336b4b42f8de35


COMMENTS

author: Brenden Conley
date: 2013-01-23 18:02:40.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1132/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-23 18:14:42.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1132/ : SUCCESS

-------------------------------------
author: Erick Ross
date: 2013-01-23 19:05:38.000000000

Patch Set 1:

I'm looking into this one as I have some concerns.

-------------------------------------
author: Erick Ross
date: 2013-01-24 11:42:53.000000000

Patch Set 1: I would prefer that you didn't submit this

(4 inline comments)

Comments inlined.

Line:57, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/structures/ScriptConsole.java -> Drop the static.

Line:108, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/structures/ScriptConsole.java -> Drop the static here too.

Line:112, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/structures/ScriptConsole.java -> And here too.

Line:58, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/actions/StopScriptAction.java -> I would prefer this to become ScriptConsole.getActive().addActiveConsoleObserver(). This would allow observers to be per console and not some shared data.

-------------------------------------
