DESCRIPTION

TMF: Event matching and TCP event list

Added a new abstract class to match tracing events.
Also added the TcpEventStrings class to add to lttng the events provided
by the additional lttng kernel module 'addons'.

+ Changed to Hashtable<...>[] to List<Map<...>>

Change-Id: I934016b1c5b1d802cf7ccbc4f95c5563bffa10ba


COMMENTS

author: Annalise Jimenez
date: 2013-01-17 20:21:26.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2013-01-17 20:21:31.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1060/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-17 20:33:51.000000000

Patch Set 3: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1060/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2013-01-17 22:58:53.000000000

Patch Set 3: I would prefer that you didn't submit this

(3 inline comments)



Line:38, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/matching/TmfEventMatching.java -> Here too, check if these fields could be private and/or final.

The type should be ITmfTrace also, to support trace types that don't go through TmfTrace (also in the constructor parameters)

Line:162, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/matching/TmfEventMatching.java -> Nitpick: multiline comments should have the /* on the first line by itself.

Line:168, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/matching/TmfEventMatching.java -> Here too, can use for (ITmfEvent event : fTraces[i]) {

-------------------------------------
