DESCRIPTION

Fix bug 396956 - [TMF] The TMF event editor should
support the model URI of a trace event)

Change-Id: I03cc2b1b34760fe3d9f9c9139cd4c0dca77a6670


COMMENTS

author: Ivy Mitchell
date: 2013-01-16 14:26:19.000000000

Patch Set 1: Looks good to me, but someone else must approve

Looks good, I like the separate file for constants.

-------------------------------------
author: Ivy Mitchell
date: 2013-01-16 14:27:20.000000000

Patch Set 1: IP review completed

Looks like the IP is clean too. 
Patch < 100 lines

-------------------------------------
author: Ivy Mitchell
date: 2013-01-16 15:48:14.000000000

Patch Set 1: No score

(5 inline comments)

More reviews. 
Some MINOR adjustments need to be made, the idea is great.

Line:592, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> Should we check if the modelURI is null?
MODEL_URI
final also please

Line:597, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> final?

Line:611, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> since modelURI an CtfCustomAttributes.modelURI are the same name, this is harder to read.

Line:612, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> Check out the naming convention for constants here

Line:618, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> This is not the best way to handle exceptions.

-------------------------------------
author: Braxton Mccarthy
date: 2013-01-16 16:43:52.000000000

MISMATCHED INLINE COMMENT
Line:8, /COMMIT_MSG -> It's important to leave an empty line between the title (first line) and rest of the description. It can break rebase, log, etc. with some tools.

-------------------------------------
author: Braxton Mccarthy
date: 2013-01-16 16:43:52.000000000

MISMATCHED INLINE COMMENT
Line:19, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfCustomAttributes.java -> class could be abstract, but it doesn't really matter...

-------------------------------------
author: Braxton Mccarthy
date: 2013-01-16 16:43:52.000000000

MISMATCHED INLINE COMMENT
Line:591, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> missing space between if and (

in a couple other places too

-------------------------------------
author: Braxton Mccarthy
date: 2013-01-16 16:43:52.000000000

MISMATCHED INLINE COMMENT
Line:617, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/events/TmfEventsTable.java -> put catch on the same line as }

-------------------------------------
author: Braxton Mccarthy
date: 2013-01-16 16:43:52.000000000

MISMATCHED INLINE COMMENT
Line:20, lttng/org.eclipse.linuxtools.tmf.ui/META-INF/MANIFEST.MF -> Non-platform dependencies should go under Import-Package instead of Require-Bundle. This allows us to build the plugins outside of Eclipse.

-------------------------------------
