DESCRIPTION

Make Run With Chart button local by default

Change-Id: I51e95b3c1b0a529d630d2b93a8857d693cbef22c


COMMENTS

author: Kamila Nguyen
date: 2013-01-09 16:16:58.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2013-01-09 16:17:04.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/940/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-09 16:29:43.000000000

Patch Set 3: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/940/ : SUCCESS

-------------------------------------
author: Erick Ross
date: 2013-01-09 18:41:15.000000000

Patch Set 3: I would prefer that you didn't submit this

(4 inline comments)



Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.graphicalrun/src/org/eclipse/linuxtools/internal/systemtap/ui/graphicalrun/actions/Messages.java -> Missing license header.

Line:48, systemtap/org.eclipse.linuxtools.systemtap.ui.graphicalrun/src/org/eclipse/linuxtools/internal/systemtap/ui/graphicalrun/actions/RunScriptChartAction.java -> Using ErrorDialog http://wiki.eclipse.org/FAQ_How_do_I_inform_the_user_of_a_problem%3F is the recommended way so the stacktrace can be easily visible to the author too.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.graphicalrun/src/org/eclipse/linuxtools/internal/systemtap/ui/graphicalrun/actions/messages.properties -> Missing license header.

Line:124, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/actions/RunScriptBaseAction.java -> scriptConsoleInitialized(console) is the last thing in both the if and else clauses, please move it outside of the if/else structure.

-------------------------------------
author: Octavio Lucero
date: 2013-01-11 17:20:55.000000000

Patch Set 3: Verified

Apart from the Alex's comments, this patch works for me.

-------------------------------------
author: Kamila Nguyen
date: 2013-01-11 19:47:28.000000000

Patch Set 3: (4 inline comments)



Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.graphicalrun/src/org/eclipse/linuxtools/internal/systemtap/ui/graphicalrun/actions/Messages.java -> Done

Line:48, systemtap/org.eclipse.linuxtools.systemtap.ui.graphicalrun/src/org/eclipse/linuxtools/internal/systemtap/ui/graphicalrun/actions/RunScriptChartAction.java -> Done

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.graphicalrun/src/org/eclipse/linuxtools/internal/systemtap/ui/graphicalrun/actions/messages.properties -> Done

Line:124, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/actions/RunScriptBaseAction.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2013-01-14 22:13:28.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
