DESCRIPTION

Make Run With Chart button local by default

Change-Id: I51e95b3c1b0a529d630d2b93a8857d693cbef22c


COMMENTS

author: Kamila Nguyen
date: 2013-01-08 19:35:33.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2013-01-08 19:41:24.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/926/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-08 19:55:31.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/926/ : SUCCESS

-------------------------------------
author: Erick Ross
date: 2013-01-09 12:22:18.000000000

Patch Set 2: Verified; I would prefer that you didn't submit this; IP review completed

(2 inline comments)

Few small comments.

Line:37, systemtap/org.eclipse.linuxtools.systemtap.ui.graphicalrun/src/org/eclipse/linuxtools/internal/systemtap/ui/graphicalrun/actions/RunScriptChartAction.java -> xxx@xxx.xxx annotation.

Line:45, systemtap/org.eclipse.linuxtools.systemtap.ui.graphicalrun/src/org/eclipse/linuxtools/internal/systemtap/ui/graphicalrun/actions/RunScriptChartAction.java -> Please don't print stack trace. If you don't care about the exception you would better add comment why it is ignored, if you do care please handle it properly.

-------------------------------------
author: Gerrit Code Review
date: 2013-01-14 22:13:28.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
