DESCRIPTION

Refactor TmfRequest

Change-Id: I72480990880adae6036e5d5c74966f250a46a6c2
Signed-off-by: Janet Compton xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2013-01-07 18:20:23.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/890/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-07 18:34:12.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/890/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2013-01-08 16:07:10.000000000

Patch Set 2: (3 inline comments)

Detected API Compatibility errors:

Missing @since tag on org.eclipse.linuxtools.tmf.core.request.TmfRequest	TmfRequest.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/request	line xxx@xxx.xxx tag problem
Missing @since tag on org.eclipse.linuxtools.tmf.core.request.TmfEventTypeFilter	TmfEventTypeFilter.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/request	line xxx@xxx.xxx tag problem
Missing @since tag on coalesceDataRequest(ITmfRequest)	TmfDataProvider.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component	line xxx@xxx.xxx tag problem
Missing @since tag on org.eclipse.linuxtools.tmf.core.request.TmfRangeFilter	TmfRangeFilter.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/request	line xxx@xxx.xxx tag problem
Missing @since tag on isCompleted(ITmfRequest, ITmfEvent, int)	TmfDataProvider.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component	line xxx@xxx.xxx tag problem
Missing @since tag on org.eclipse.linuxtools.tmf.core.request.TmfBlockFilter	TmfBlockFilter.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/request	line xxx@xxx.xxx tag problem
Missing @since tag on newCoalescedDataRequest(ITmfRequest)	TmfDataProvider.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component	line xxx@xxx.xxx tag problem
Missing @since tag on queueBackgroundRequest(ITmfRequest, boolean)	TmfDataProvider.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component	line xxx@xxx.xxx tag problem
Missing @since tag on sendRequest(ITmfRequest)	TmfDataProvider.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component	line xxx@xxx.xxx tag problem
Invalid @since 1.1 tag on getUnion(TmfTimeRange); expecting @since 2.0	TmfTimeRange.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event	line xxx@xxx.xxx tag problem
Missing @since tag on queueRequest(ITmfRequest)	TmfDataProvider.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component	line xxx@xxx.xxx tag problem
Missing @since tag on org.eclipse.linuxtools.tmf.core.component.ITmfEventProvider	ITmfEventProvider.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component	line xxx@xxx.xxx tag problem
Missing @since tag on org.eclipse.linuxtools.tmf.core.request.ITmfRequest	ITmfRequest.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/request	line xxx@xxx.xxx tag problem
Missing @since tag on sendRequest(ITmfRequest)	ITmfDataProvider.java	/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/component	line xxx@xxx.xxx tag problem

Line:216, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfExperiment.java -> Same comment as for TmfTrace

Line:709, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java -> The setStartIndex() was previously used I believe only to be able to properly arm the subsequent subrequests of a split background request. Perhaps we don't need the block filter?

Line:44, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/histogram/HistogramCurrentTimeControl.java -> Leftover from merge conflict?

-------------------------------------
