DESCRIPTION

CTF: Add support for custom attributes in an event
     Use IEventDeclaration now to create a proper API

Signed-off-by: Ivy Mitchell xxx@xxx.xxx
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx
Change-Id: I398cb479e087ec5bdec54933702b6cc8ecdfc805


COMMENTS

author: Ivy Mitchell
date: 2013-01-08 21:43:41.000000000

Uploaded patch set 6.

-------------------------------------
author: Brenden Conley
date: 2013-01-08 21:43:46.000000000

Patch Set 6:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/929/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-08 21:56:50.000000000

Patch Set 6: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/929/ : SUCCESS

-------------------------------------
author: Ivy Mitchell
date: 2013-01-08 23:00:05.000000000

Patch Set 6: (2 inline comments)

My own bugs... not worth a -1.

Line:7, /COMMIT_MSG -> blank space too

Line:1, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/ctfadaptor/CtfTmfEventTest.java -> 2013

-------------------------------------
author: Braxton Mccarthy
date: 2013-01-09 15:33:27.000000000

Patch Set 6: (1 inline comment)

The IEventDeclaration introduction should really be split in a separate commit. The addition of the custom attributes map could then sit on top of it.

Line:222, lttng/org.eclipse.linuxtools.tmf.core.tests/src/org/eclipse/linuxtools/tmf/core/tests/ctfadaptor/CtfTmfEventTest.java -> You can use Set<String> here now, but it doesn't really matter...

-------------------------------------
author: Luciana Barry
date: 2013-01-09 22:02:15.000000000

Patch Set 6: (5 inline comments)



Line:22, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/IEventDeclaration.java -> events.s

Line:60, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/IEventDeclaration.java -> am > an, is "return id..." a typo?

Line:67, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/IEventDeclaration.java -> am > an

Line:83, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/IEventDeclaration.java -> attributes

Line:91, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/event/IEventDeclaration.java -> ctf > CTF for consistency

-------------------------------------
