DESCRIPTION

Add support for link with editor in tracing projects

- Extend extension org.eclipse.ui.navigator.linkHelper
- Add implementation of ILinkHelper interface
- Implement getParent() in TmfNavigatorContentProvider

Change-Id: I6e37bff9b7891866a61f2a0960e789d8bfbc5fa5


COMMENTS

author: Brenden Conley
date: 2012-12-14 16:45:33.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/792/ 

-------------------------------------
author: Brenden Conley
date: 2012-12-14 16:58:16.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/792/ : SUCCESS

-------------------------------------
author: Luciana Barry
date: 2012-12-14 19:16:04.000000000

Patch Set 1: (6 inline comments)



Line:1187, lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml -> New package org.eclipse.linuxtools.internal.tmf.ui.project.model should be added to Runtime exported packages in MANIFEST.MF (hidden from all plug-ins).

Line:84, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/model/TmfEditorLinkHelper.java -> The second part of the if-clause is unnecessary, the file's parent is the Traces folder.

Line:109, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/model/TmfEditorLinkHelper.java -> rename fTrace (not a class field variable)

Line:140, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/model/TmfEditorLinkHelper.java -> Could use IEditorPart returned by getEditor(true) above. Maybe after a null check?

Line:66, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfNavigatorContentProvider.java -> point of (view)

Line:78, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfNavigatorContentProvider.java -> point of (view)

-------------------------------------
author: Ricky Reeves
date: 2012-12-18 01:36:14.000000000

Patch Set 1: (6 inline comments)



Line:1187, lttng/org.eclipse.linuxtools.tmf.ui/plugin.xml -> Done

Line:84, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/model/TmfEditorLinkHelper.java -> Done

Line:109, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/model/TmfEditorLinkHelper.java -> Done

Line:140, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/internal/tmf/ui/project/model/TmfEditorLinkHelper.java -> Make sense. Done

Line:66, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfNavigatorContentProvider.java -> Done

Line:78, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/project/model/TmfNavigatorContentProvider.java -> Done

-------------------------------------
