DESCRIPTION

Bug 396505: Open Error Dialog when stap script name is of improper form.

Stop script execution and open error dialog when script name is not of
the form ^[a-z0-9_]+(.stp)$ . This a temporary fix, the stap tool itself
should handle module naming in the future.

Change-Id: Id8e92c642f9f539d6fee64a9fe2f48c7221b699a


COMMENTS

author: Octavio Lucero
date: 2012-12-14 17:37:47.000000000

Uploaded patch set 4.

-------------------------------------
author: Brenden Conley
date: 2012-12-14 17:37:52.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/793/ 

-------------------------------------
author: Brenden Conley
date: 2012-12-14 17:49:30.000000000

Patch Set 4: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/793/ : SUCCESS

-------------------------------------
author: Kamila Nguyen
date: 2012-12-14 20:56:00.000000000

Patch Set 4: (3 inline comments)



Line:297, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/actions/RunScriptBaseAction.java -> The following code should be moved outside the if/else because it applies to both local and remote run scripts

Line:301, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/actions/RunScriptBaseAction.java -> I think you just do if(!modname.matches(...))

Line:2, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/actions/messages.properties -> Much better than staps error message :)

-------------------------------------
