DESCRIPTION

Bug 391608: RFE: Extend CDT launch to support profiling
https://bugs.eclipse.org/bugs/show_bug.cgi?id=391608

Change-Id: I27f6e69ed4566aad420095db93e075ef0d9204a0


COMMENTS

author: Kaylin Maxwell
date: 2013-01-24 22:06:32.000000000

Uploaded patch set 8.

-------------------------------------
author: Brenden Conley
date: 2013-01-24 22:06:37.000000000

Patch Set 8:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/1152/ 

-------------------------------------
author: Brenden Conley
date: 2013-01-24 22:24:24.000000000

Patch Set 8: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/1152/ : SUCCESS

-------------------------------------
author: Amir Petty
date: 2013-01-25 11:40:44.000000000

Patch Set 8: (2 inline comments)



Line:434, profiling/org.eclipse.linuxtools.profiling.launch/plugin.xml -> I think the name of the tab should be translatable, so should be in plugin.properties (below tabs as well)

Line:46, profiling/org.eclipse.linuxtools.profiling.launch/src/org/eclipse/linuxtools/internal/profiling/launch/CProfilingOptionsTab.java -> I think you need to override getId()

-------------------------------------
author: Kaylin Maxwell
date: 2013-01-25 20:00:49.000000000

Patch Set 8: (2 inline comments)



Line:434, profiling/org.eclipse.linuxtools.profiling.launch/plugin.xml -> Done

Line:46, profiling/org.eclipse.linuxtools.profiling.launch/src/org/eclipse/linuxtools/internal/profiling/launch/CProfilingOptionsTab.java -> Done

-------------------------------------
