DESCRIPTION

Implement TmfIntervalTimestamp for deltas of timestamps

The toString() method of this class returns the timestamp string
formatted with TmfTimestampFormat.DefaultIntervalFormat() and 
also considers negative values correctly.

The getDelta() method of TmfTimestamp and TmfSimpleTimestamp
returns now a instance of TmfIntervalTimestamp.

This also fixes the incorrect display of timestamps deltas in
the Sequence Diagram view.

Change-Id: I249ab9ac7a5f4170f86f038bc89d419dcce9514a


COMMENTS

author: Brenden Conley
date: 2012-11-29 20:45:42.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/689/ 

-------------------------------------
author: Brenden Conley
date: 2012-11-29 21:00:21.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/689/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2012-11-29 21:31:09.000000000

Patch Set 1:

Looks like a very good idea.

Only comment, I would instead call it "TmfTimestampDelta" or something similar, because it is not an interval per se (as in having a start time and end time in the object itself, like ITmfStateInterval).

-------------------------------------
author: Luciana Barry
date: 2012-11-29 23:19:17.000000000

Patch Set 1: (2 inline comments)



Line:80, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/TmfIntervalTimestamp.java -> Should we override normalize() so that it returns a TmfIntervalTimestamp?

Line:92, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/TmfIntervalTimestamp.java -> Should we override toString(TmfTimestampFormat) to support things like HH:mm:ss?

-------------------------------------
author: Ricky Reeves
date: 2012-11-30 14:47:14.000000000

Patch Set 1: (2 inline comments)

Yes, TmfTimestampDelta is better name. I'll change it.

BTW, initially I used TmfDeltaTimestamp, but then I didn't like it. TmfTimestampDelta fits well.

Line:80, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/TmfIntervalTimestamp.java -> Yes, it's a good Idea

Line:92, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/TmfIntervalTimestamp.java -> No need to override the method. This method is available for the users from the super class.

-------------------------------------
