DESCRIPTION

Bug 507994 - RFE: support --net option in Docker run image UI

- add new ImageRunNetworkModel class
- add new ImageRunNetworkPage class
- add ImageRunNetworkPage to ImageRun pages list
- use networkMode string from ImageRunNetworkModel to fill
  hostConfig for ImageRun.getHostConfig()
- add setting network mode to LaunchConfigurationUtils
- same for RunDockerImageLaunchConfigurationDelegate
- fix id of ImageRunResourceVolumesVariablesPage to be unique
- add new RunImageNetworkTab class to list of tabs for
  Run Image configuration
- add network tab icon
- add networkMode to MockContainerInfoFactory builder
- add networkMode to MockDockerHostConfigFactory builder
- add new network mode tests to DockerContainersViewSWTBotTest
- add a network mode assertion to EditDockerConnectionSWTBotTest
  test

Change-Id: I4e650709ab4c38fc9e3514ab93465ffa807495f8


COMMENTS

author: Kaylin Maxwell
date: 2017-01-24 20:57:03.000000000

Uploaded patch set 3.

-------------------------------------
author: Brenden Conley
date: 2017-01-24 20:57:09.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/11437/

-------------------------------------
author: Kaylin Maxwell
date: 2017-01-24 20:57:44.000000000

Patch Set 3: -Code-Review

-------------------------------------
author: Brenden Conley
date: 2017-01-24 21:28:08.000000000

Patch Set 3: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/11437/ : SUCCESS

-------------------------------------
author: Nathanael Holden
date: 2017-01-25 18:24:15.000000000

Patch Set 3: Verified+1

Seems to work well for me.

I wonder if the combo box for "Container" should only be as wide as it's largest entry (instead of expanding horizontally to take all space). When I select it from the dropdown the entry that comes up would generally be less wide so it looks strange.

-------------------------------------
author: Gerrit Code Review
date: 2017-01-26 21:56:04.000000000

Change has been successfully cherry-picked as cf6165c32874d362682e356364ef8629bda101ec by Kaylin Maxwell

-------------------------------------
