DESCRIPTION

Remove blanket Exception catching

Remove trailing whitespace.
Remove dead code.
Organize imports.
Add //$NON-NLS-1$

Change-Id: I50bc8b3f04f804c2f5a0b71aaba7234b7e001bb0


COMMENTS

author: Brenden Conley
date: 2012-11-27 21:52:25.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/660/ 

-------------------------------------
author: Brenden Conley
date: 2012-11-27 22:16:05.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/660/ : SUCCESS

-------------------------------------
author: Erick Ross
date: 2012-11-28 09:36:28.000000000

Patch Set 1: (4 inline comments)

See inline comments for some small things to be fixed.

Line:45, systemtap/org.eclipse.linuxtools.callgraph.core/src/org/eclipse/linuxtools/internal/callgraph/core/ViewFactory.java -> Is it safe to throw RuntimeException instead of Exception. This changes the semantic aka from checked to unchecked exception. Actually why is this exception actually thrown? The usual way of handling such stuff is to do nothing when instanceof check doesn't satisfy the code.

Line:72, systemtap/org.eclipse.linuxtools.callgraph.core/src/org/eclipse/linuxtools/internal/callgraph/core/ViewFactory.java -> Same as previous comment.

Line:105, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/Subscription.java -> There is no need to add printing of the stack trace if there is ErrorMessage. The right thing would be to add the stack trace to the message itself.

Line:273, systemtap/org.eclipse.linuxtools.callgraph.core/src/org/eclipse/linuxtools/internal/callgraph/core/SystemTapParser.java -> Please xxx@xxx.xxx Exception. It's no longer true.

-------------------------------------
author: Kamila Nguyen
date: 2012-11-28 19:45:09.000000000

Patch Set 1: (4 inline comments)



Line:45, systemtap/org.eclipse.linuxtools.callgraph.core/src/org/eclipse/linuxtools/internal/callgraph/core/ViewFactory.java -> Yeah that makes sense. I have changed it to just return if the instanceof is not satisfied.

Line:72, systemtap/org.eclipse.linuxtools.callgraph.core/src/org/eclipse/linuxtools/internal/callgraph/core/ViewFactory.java -> Done

Line:105, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/Subscription.java -> Done

Line:273, systemtap/org.eclipse.linuxtools.callgraph.core/src/org/eclipse/linuxtools/internal/callgraph/core/SystemTapParser.java -> Done

-------------------------------------
