DESCRIPTION

Add timezones to preference page

Change-Id: I88281ba937889b816d846ac60a1e7c46d04ff34e
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2012-11-27 16:35:14.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/657/ 

-------------------------------------
author: Brenden Conley
date: 2012-11-27 17:18:51.000000000

Patch Set 3: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/657/ : SUCCESS

-------------------------------------
author: Braxton Mccarthy
date: 2012-11-27 17:19:22.000000000

Patch Set 3: I would prefer that you didn't submit this

(9 inline comments)

Some comments.

There is without doubt good work here, but imo it's obviously rushed, and should not be part of the internal release. I'll defer to what the other team members think about this.

Line:99, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimestampFormatPage.java -> oh boy that is not pretty :P

should use SuppressWarnings("nls") at the method level instead. also please format the array correctly.

new String[] {

"GMT-12",

"GMT-11",

etc.

Line:176, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimestampFormatPage.java -> no

Line:193, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimestampFormatPage.java -> no no

Line:210, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimestampFormatPage.java -> ctrl+shift+f

Line:277, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/TmfTimestampFormat.java -> is this a user-provided time zone? What happens if it's not recognized?

Line:83, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimePreferences.java -> Why do you need both a static and a non-static field? Shouldn't the static one be enough?

Line:84, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimePreferences.java -> extra line

Line:158, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimePreferences.java -> there is javadoc for this method, it should be updated

Line:61, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphScale.java -> This should not be done manually. Maybe this class should extend TmfComponent?

-------------------------------------
author: Ivy Mitchell
date: 2012-11-27 18:12:48.000000000

Patch Set 3: (2 inline comments)

replies

-------------------------------------
author: Luciana Barry
date: 2012-11-27 18:26:07.000000000

Patch Set 3: Fails

Testing on Windows:
- The first time I opened the Time Format preferences, the Time Zone was set to GMT-12:00.
- None of the items in the Time Zone combo box have the (local) label.

-------------------------------------
author: Kaeden Tapia
date: 2013-05-09 22:57:31.000000000

Patch Set 3: (5 inline comments)

I pushed a new change because it's now for the master branch. See
https://git.eclipse.org/r/#/c/12700/

Line:99, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimestampFormatPage.java -> Done

Line:210, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimestampFormatPage.java -> Done

Line:83, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimePreferences.java -> I don't think it's necessary.

Line:158, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimePreferences.java -> Done

Line:61, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/widgets/timegraph/widgets/TimeGraphScale.java -> I don't think that's possible. It needs to extend Canvas so it can't extend TmfComponent at the same time.

-------------------------------------
author: Braxton Mccarthy
date: 2013-05-10 18:01:53.000000000

Patch Set 3: Abandoned

Obsolete, replaced by https://git.eclipse.org/r/#/c/12700/

-------------------------------------
author: Ivy Mitchell
date: 2012-11-27 18:12:47.000000000

MISMATCHED INLINE COMMENT
Line:277, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/event/TmfTimestampFormat.java -> nope, it's a preference provided timezone

-------------------------------------
author: Ivy Mitchell
date: 2012-11-27 18:12:47.000000000

MISMATCHED INLINE COMMENT
Line:83, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/properties/TmfTimePreferences.java -> the static is for allowing comunication "upstream" from tmf-ui to tmf-core.

-------------------------------------
