DESCRIPTION

Add global keyword completion

And
- Propose prope points only when preceded by 'probe'
- Complete first and second sections of probe points
  independently to reduce noise.
- Remove dead code.

Change-Id: I05d44f90afa93cbb3d72882b707794bc60ecce1c


COMMENTS

author: Octavio Lucero
date: 2012-11-09 22:48:27.000000000

Patch Set 3:

Used "Rebase Change" button to rebase this change due to merged dependencies.

-------------------------------------
author: Brenden Conley
date: 2012-11-09 23:20:43.000000000

Patch Set 3:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/548/ 

-------------------------------------
author: Brenden Conley
date: 2012-11-09 23:47:21.000000000

Patch Set 3: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/548/ : SUCCESS

-------------------------------------
author: Octavio Lucero
date: 2012-11-13 21:47:47.000000000

Patch Set 3: (2 inline comments)

Change works as intended, and fixes a number of errors occurring when
auto-completing malformed scripts.Just a comment regarding a npe.

Line:82, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/editors/stp/STPMetadataSingleton.java -> Npe thrown in this line when the completion hint is of the form "<invalid tapset><period>". A null check is a quick fix for this minor issue.

Line:70, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/editors/stp/STPCompletionProcessor.java -> If prefix is invalid (e.g. "probe <invalid tapset><period>") a npe is thrown in STPMetadataSingleton#getProbeCompletionList (line 82 of this patch set), since the metadata map is returning null.

-------------------------------------
author: Kamila Nguyen
date: 2012-11-14 21:23:56.000000000

Patch Set 3: (2 inline comments)

I have fixed and added a test case for the problem mentioned

Line:82, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/editors/stp/STPMetadataSingleton.java -> Done

Line:70, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/editors/stp/STPCompletionProcessor.java -> Done

-------------------------------------
