DESCRIPTION

Support running stap locally as current user

Change-Id: Ifd58f2f4c2ac06b2302a3ce57bab758d4586e272


COMMENTS

author: Kamila Nguyen
date: 2012-10-23 19:45:37.000000000

Uploaded patch set 7.

-------------------------------------
author: Brenden Conley
date: 2012-10-23 21:24:56.000000000

Patch Set 7:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/431/ 

-------------------------------------
author: Brenden Conley
date: 2012-10-23 21:42:34.000000000

Patch Set 7: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/431/ : SUCCESS

-------------------------------------
author: Erick Ross
date: 2012-10-24 08:06:32.000000000

Patch Set 7: (2 inline comments)

Comments inlined.

Line:72, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/LocalLoggedCommand.java -> Why catch NPE ? We would better do null check for null if/where needed and remove the NPE check. By catching and ignoring NPE we ignore every possibility of smth not initialized when probably only a few things can be null.

Line:148, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/structures/ScriptConsole.java -> Don't catch Exception. Catch only what is actually thrown.

-------------------------------------
author: Kamila Nguyen
date: 2012-10-24 17:46:42.000000000

Patch Set 7: (2 inline comments)

Made requested changes.

Line:72, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/LocalLoggedCommand.java -> Done

Line:148, systemtap/org.eclipse.linuxtools.systemtap.ui.consolelog/src/org/eclipse/linuxtools/systemtap/ui/consolelog/structures/ScriptConsole.java -> Done

-------------------------------------
