DESCRIPTION

Create a skeletorn SystemTap run configuration implementation

Change-Id: I95c263f1a54d74725eb2fa6f519954009afe91d9


COMMENTS

author: Kamila Nguyen
date: 2012-10-22 18:19:14.000000000

Uploaded patch set 4.

-------------------------------------
author: Nathanael Holden
date: 2012-10-22 19:02:34.000000000

Patch Set 4: I would prefer that you didn't submit this

(6 inline comments)

This is implemented fine but just some minor tweaks needing to be made.

Line:7, /COMMIT_MSG -> Fix typos here.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/launcher/SystemTapScriptLaunchConfigurationDelegate.java -> Copyright headers.

Line:320, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/plugin.xml -> This should be org.eclipse.linuxtools.internal.systemtap.ui.ide .. to point to the right class.

Line:1, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/launcher/SystemTapScriptLaunchConfigurationTabGroup.java -> Missing copyright header.

Line:2, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/launcher/SystemTapScriptLaunchConfigurationTab.java -> Missing copyright headers.

Line:18, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/launcher/SystemTapScriptLaunchConfigurationTab.java -> Some of the strings here should probably be externalized.

-------------------------------------
author: Brenden Conley
date: 2012-10-22 19:33:41.000000000

Patch Set 4:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/390/ 

-------------------------------------
author: Brenden Conley
date: 2012-10-22 19:52:11.000000000

Patch Set 4: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/390/ : SUCCESS

-------------------------------------
