DESCRIPTION

Add new Systemtap Wizard for new scripts

This patch adds the initial systemtap wizard implementation.  The
manifest and plugin.xml file have been modified for this extention.  The
use is prompted for script name (must end in .stp) and can broswer to
their desired folder.  '#!/usr/bin/env stap' is applied automatically to
the beginning of the new file and the proper perspective is
automatically shown.

Change-Id: I46414863af975f2299e22ba112c216b11f47ade7


COMMENTS

author: Brenden Conley
date: 2012-10-03 17:16:31.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/282/ 

-------------------------------------
author: Brenden Conley
date: 2012-10-03 17:28:22.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/282/ : SUCCESS

-------------------------------------
author: Kamila Nguyen
date: 2012-10-03 18:53:14.000000000

Patch Set 1: Verified; Unclean IP, do not check in

(5 inline comments)

The license situation of the image still has to be clarified, but please address the other issues mentioned inline.

Line:52, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/wizards/StapNewWizardPage.java -> Strings like these should be externalized. You can look else where in the code base for examples of this.

Line:69, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/wizards/StapNewWizardPage.java -> externalize.

Line:115, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/wizards/StapNewWizard.java -> The following code does not need to be inside the if statement does it ?

Line:121, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/wizards/StapNewWizard.java -> createNewFile will check if a file exists and only create one if it does not. So there is no need to check if the files exits.

Line:124, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/wizards/StapNewWizard.java -> to avoid writing characters one byte at a time you can use write(envOut.getBytes())

-------------------------------------
