DESCRIPTION

Bug 390874: Add gprof to Profile Timing category
https://bugs.eclipse.org/bugs/show_bug.cgi?id=390874

- Add o.e.l.gprof.launch plug-in

Change-Id: Ifb8c47eb4007544fc8a4b393af57eb1017f0fbb1


COMMENTS

author: Kaylin Maxwell
date: 2012-10-03 17:03:43.000000000

Uploaded patch set 2.

-------------------------------------
author: Brenden Conley
date: 2012-10-03 17:03:48.000000000

Patch Set 2:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/281/ 

-------------------------------------
author: Brenden Conley
date: 2012-10-03 17:16:31.000000000

Patch Set 2: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/281/ : SUCCESS

-------------------------------------
author: Octavio Lucero
date: 2012-10-03 20:06:11.000000000

Patch Set 2: (3 inline comments)

Everything works, just minor issues with the warning messages/dialog boxes.

Line:16, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchMessages.properties -> Mismatch between this message definition and the respective declaration in GprofLaunchMessages. This should be just GprofGmonStale_msg.

Line:17, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchMessages.properties -> Same as above. This should be GprofGmonStaleExplanation_msg.

Line:130, gprof/org.eclipse.linuxtools.gprof.launch/src/org/eclipse/linuxtools/internal/gprof/launch/GprofLaunchConfigurationDelegate.java -> This condition will always be true if a gmon.out file does not exist, since in that case f.fetchInfo().getLastModified() returns 0. This results in the two warning dialog boxes opening consecutively in the absence of a gmon.out file . Returning after opening a warning dialog box should fix this.

-------------------------------------
