DESCRIPTION

tmf: Add an ID to each state system that gets built

When requesting to build a state system, we now need to specify
a String ID. This ID will be returned with the "state system build
completed" signal, so that a view can differentiate between many
state systems that could be associated to the same trace.

Change-Id: I699d46f3a3cf7300f71282f505eeb40e08cb4d1e
Signed-off-by: Braxton Mccarthy xxx@xxx.xxx


COMMENTS

author: Brenden Conley
date: 2012-09-28 22:37:24.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/sandbox/job/linuxtools/259/ 

-------------------------------------
author: Brenden Conley
date: 2012-09-28 22:48:31.000000000

Patch Set 1: Verified

Build Successful 

https://hudson.eclipse.org/sandbox/job/linuxtools/259/ : SUCCESS

-------------------------------------
author: Ricky Reeves
date: 2012-10-01 13:33:20.000000000

Patch Set 1: (2 inline comments)



Line:48, lttng/org.eclipse.linuxtools.lttng2.kernel.core/src/org/eclipse/linuxtools/lttng2/kernel/core/trace/CtfKernelTrace.java -> Should we use a more qualifying name e.g. org.eclipse.linuxtools.lttng.kernel" to avoid any name clashes?

Line:46, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statistics/TmfStatistics.java -> Should we use a more qualifying name e.g. org.eclipse.linuxtools.tmf.statistics" to avoid any name clashes?

-------------------------------------
author: Braxton Mccarthy
date: 2012-10-01 14:48:13.000000000

Patch Set 1: (2 inline comments)

Thanks for the comments, yes, I will update the ID names in the next version.

Line:48, lttng/org.eclipse.linuxtools.lttng2.kernel.core/src/org/eclipse/linuxtools/lttng2/kernel/core/trace/CtfKernelTrace.java -> How about lttng2.kernel?  But yes, good point.

Line:46, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/statistics/TmfStatistics.java -> Yep, good point.

-------------------------------------
author: Braxton Mccarthy
date: 2012-10-01 15:16:45.000000000

Patch Set 1: I would prefer that you didn't submit this

(tagging that a new version will be needed)

-------------------------------------
