DESCRIPTION

Improve retreval of active script editor

- Add setter and getter to IDESessionSettings for the active
  editor.
- If there is only one systemtap script editor open and no
  active editor has been set, use that one.

Change-Id: I9738233c05bd5579d84ef800eefbecbdaa71fa44


COMMENTS

author: Erick Ross
date: 2012-08-24 12:29:23.000000000

Patch Set 1: (2 inline comments)



Line:30, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/IDESessionSettings.java -> This is an API change as public member is hidden.

Line:159, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/actions/hidden/KernelSourceAction.java -> Printing stack trace is not a good practice. It is hard to find it unless you start eclipse from console with console switch.

-------------------------------------
author: Kamila Nguyen
date: 2012-08-24 16:03:15.000000000

Patch Set 1: (1 inline comment)



Line:30, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/IDESessionSettings.java -> Can I deprecate it, and add a fixme to say that it should be changed to private in the next release ?

I'll xxx@xxx.xxx to the getter and setter BTW.

-------------------------------------
author: Kamila Nguyen
date: 2012-08-24 20:09:36.000000000

Patch Set 1: (2 inline comments)



Line:30, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/systemtap/ui/ide/IDESessionSettings.java -> Done

Line:159, systemtap/org.eclipse.linuxtools.systemtap.ui.ide/src/org/eclipse/linuxtools/internal/systemtap/ui/ide/actions/hidden/KernelSourceAction.java -> Done

-------------------------------------
author: Gerrit Code Review
date: 2012-08-29 08:41:08.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
