DESCRIPTION

tmf: Refactor the statistics

Manages the viewer input directly in the viewer rather than in the view.

Change-Id: I2ed5ee303036d384939d5a2a121e30462c9c9fb7
Signed-off-by: Arabella Bonilla xxx@xxx.xxx


COMMENTS

author: Simeon Moses
date: 2012-08-21 19:45:57.000000000

Uploaded patch set 2.

-------------------------------------
author: Braxton Mccarthy
date: 2012-08-21 20:32:23.000000000

Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)



Line:9, /COMMIT_MSG -> I'd say "Manage" here.

Can't really say "[This patch] manages the viewer input".

Line:552, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> Comment types should be uniform within the same file. I'd suggest /* */ everywhere ;)

Line:79, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/model/TmfStatisticsTreeRootFactory.java -> The (capital T) .... tree, or null (comma)

-------------------------------------
author: Braxton Mccarthy
date: 2012-08-21 20:37:52.000000000

Patch Set 2: (1 inline comment)



Line:12, /COMMIT_MSG -> User name here too

-------------------------------------
author: Simeon Moses
date: 2012-08-21 21:09:08.000000000

Patch Set 2: (4 inline comments)



Line:9, /COMMIT_MSG -> Done

Line:12, /COMMIT_MSG -> Done

Line:552, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/TmfStatisticsViewer.java -> Done in the next commit I5af35217 PS2

Line:79, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/viewers/statistics/model/TmfStatisticsTreeRootFactory.java -> Done

-------------------------------------
