DESCRIPTION

Bug 491999 - Docker build fails when called via Quick Access menu

- add code to BuildImageCommandHandler to find a DockerExplorerView
  if the active part isn't the Docker Images View
- from the DockerExplorerView, extract the current selected connection
- display an error dialog if no connection can be located

Change-Id: Ic5ccd010b30ef7e9ebede73ce82a89a381fb8c78


COMMENTS

author: Kaylin Maxwell
date: 2016-05-12 21:12:45.000000000

Uploaded patch set 1.

-------------------------------------
author: Brenden Conley
date: 2016-05-12 21:12:51.000000000

Patch Set 1:

Build Started https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10784/

-------------------------------------
author: Brenden Conley
date: 2016-05-12 21:31:04.000000000

Patch Set 1: Verified+1

Build Successful 

https://hudson.eclipse.org/linuxtools/job/linuxtools-gerrit/10784/ : SUCCESS

-------------------------------------
author: Zechariah Krause
date: 2016-05-13 07:08:39.000000000

Patch Set 1: Code-Review-1

(1 comment)

The org.eclipse.linuxtools.internal.docker.ui.commands.CommandUtils class should be used to keep the code in the command handle simpler.

Line:69, containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/commands/BuildImageCommandHandler.java -> you can use CommandUtils#getCurrentConnection(IWorkbenchPart) to get the current selection, whatever the active view is: DockerContainersView, DockerExplorerView or DockerImagesView

-------------------------------------
author: Kaylin Maxwell
date: 2016-05-13 15:57:57.000000000

Patch Set 1:

(1 comment)

Line:69, containers/org.eclipse.linuxtools.docker.ui/src/org/eclipse/linuxtools/internal/docker/ui/commands/BuildImageCommandHandler.java -> But the active part won't necessarily be DockerContainersView or DockerExplorerView or any Docker view.  For example, my code works if the user is using a C editor and hits CTRL+3.  CommandUtils only handles one of the three views.

-------------------------------------
author: Kaylin Maxwell
date: 2016-05-16 18:58:58.000000000

Patch Set 2: Patch Set 1 was rebased

-------------------------------------
author: Gerrit Code Review
date: 2016-05-24 19:10:00.000000000

Change has been successfully cherry-picked as 9550e9314d1a77979efe694d479ea40b2c899418 by Kaylin Maxwell

-------------------------------------
