DESCRIPTION

Integration of the state system in the statistics

Change-Id: I1e6b9931007c79cce8c1c93c6c0ddc955cbd0a93
Signed-off-by: Simeon Moses xxx@xxx.xxx


COMMENTS

author: Braxton Mccarthy
date: 2012-07-26 19:44:51.000000000

Patch Set 1: (3 inline comments)

Very interesting work here!

Could you first
* Open a bug on the bugzilla about this (storing the statistics in the state). We will definitely want this, in the long-term.
* Add a link to this bug in the commit message.
* Document how much extra space is taken by the history file because of this. This could be a show-stopper, at least until partial histories are implemented.

We'll also have to talk with the others about the design of the whole thing. We might want to integrate this in TMF itself, so it's not only used for LTTng kernel traces (every trace type could store its statistics in a separate history file, for example).

Thanks.

Line:7, /COMMIT_MSG -> Technically, you integrate the statistics in the state system, not the other way around ;)

Line:2, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statistics/TmfStatisticsView.java -> good catch hehe

Line:21, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/plugin.properties -> Since this is LTTng-kernel specific, it should be named as such.

-------------------------------------
author: Ivy Mitchell
date: 2012-07-26 21:50:16.000000000

Patch Set 1: I would prefer that you didn't submit this

(7 inline comments)

I've put some comments up, I would like you to read them. It's good, but I think some more explanations are needed before pushing.

Line:7, /COMMIT_MSG -> Should be "Integrate statistics into the state system" ?

Line:45, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java xxx@xxx.xxx

Line:139, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java -> Why do we need this? comment please.

Line:140, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java -> why no max for end time?

Line:145, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java -> One line me?

Line:153, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java -> why -1? this strikes me as an odd behaviour being swept under the carpet.

Line:24, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemBaseStatisticsTree.java -> Does this need xxx@xxx.xxx

-------------------------------------
author: Janet Compton
date: 2012-08-03 17:04:01.000000000

Patch Set 1:

I agree with Matthew. Needs a little bit more explaining. We won't even talk about unit test :-)

-------------------------------------
author: Simeon Moses
date: 2012-08-23 18:20:22.000000000

Patch Set 1: (9 inline comments)



Line:7, /COMMIT_MSG -> Done

Line:2, lttng/org.eclipse.linuxtools.tmf.ui/src/org/eclipse/linuxtools/tmf/ui/views/statistics/TmfStatisticsView.java -> :)

Line:45, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java -> It doesn't change the API

Line:139, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java -> Done

Line:140, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java -> Done

Line:145, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java -> Done

Line:153, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemStatisticsView.java -> Done

Line:24, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/src/org/eclipse/linuxtools/internal/lttng2/kernel/ui/views/statistics/StateSystemBaseStatisticsTree.java -> It doesn't change the API

Line:21, lttng/org.eclipse.linuxtools.lttng2.kernel.ui/plugin.properties -> Done

-------------------------------------
