DESCRIPTION

Fix issues with CTF parser.

* When an enum is declared in a different scope than it is defined in.
* When there is no stream ID the trace does not generate NPEs.
* When there is no clock offset, a 0 offset is created. (not often)

Change-Id: Ie0e0e09168aa2d91ac52d49e94bc10e1e9ba691f
Signed-off-by: Ivy Mitchell xxx@xxx.xxx


COMMENTS

author: Ivy Mitchell
date: 2012-07-24 17:25:18.000000000

Uploaded patch set 2.

-------------------------------------
author: Luciana Barry
date: 2012-07-24 17:51:19.000000000

Patch Set 2: Verified; Looks good to me, approved



-------------------------------------
author: Luciana Barry
date: 2012-07-24 17:51:34.000000000

Patch Set 2: IP review completed



-------------------------------------
author: Braxton Mccarthy
date: 2012-07-24 18:41:02.000000000

Patch Set 2: I would prefer that you didn't submit this

(5 inline comments)

style comments. Unfortunately the formatter settings patch isn't merged yet ;)

Line:235, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/metadata/IOStructGen.java -> This would be clearer if it was not wrapped at all.

Line:2631, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/metadata/IOStructGen.java -> Now here is some good wrapping, it actually makes it clearer.

Line:737, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/internal/ctf/core/event/metadata/IOStructGen.java -> Here too, shouldn't be wrapped. Or you could declare "long logLevel;" outside of the "if", you'll save 5 characters each time ;)

Line:702, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java -> ) {

Line:707, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java -> } else {

-------------------------------------
author: Ivy Mitchell
date: 2012-07-24 21:27:51.000000000

Patch Set 2: (1 inline comment)

reply to alex

Line:702, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java -> )<space>{?

-------------------------------------
author: Braxton Mccarthy
date: 2012-07-24 21:40:08.000000000

Patch Set 2: (1 inline comment)



Line:702, lttng/org.eclipse.linuxtools.ctf.core/src/org/eclipse/linuxtools/ctf/core/trace/CTFTrace.java -> Yes space, curse this non-monospace font ;)

-------------------------------------
author: Gerrit Code Review
date: 2012-07-25 13:54:24.000000000

Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for review.

-------------------------------------
