DESCRIPTION

Proposed fix for slowdown.

Concerning synchronized trace and experiment seeking bug.

Change-Id: I6c59ac7ba52d80ab4bab597da93ea7adb950158d


COMMENTS

author: Ivy Mitchell
date: 2012-07-17 20:43:45.000000000

Uploaded patch set 5.

-------------------------------------
author: Braxton Mccarthy
date: 2012-07-17 21:25:56.000000000

Patch Set 5: Verified; IP review completed

(5 inline comments)

Some comments, seems to work fine. This is much cleaner than the cesspool, gj!

Line:9, /COMMIT_MSG -> How about:


Fix trace and experiment seeking bug

Also seems to improve performance.

Change-Id ...

Line:22, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfIteratorManager.java xxx@xxx.xxx 1.1/1.2 will probably be needed

Line:32, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfIteratorManager.java -> You could put this in the declaration, so no need for the .init()

Line:37, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfIteratorManager.java -> Registers

Line:78, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfIteratorManager.java -> could also be static

-------------------------------------
author: Luciana Barry
date: 2012-07-17 21:48:33.000000000

Patch Set 5: (3 inline comments)



Line:51, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfIteratorManager.java -> unregister?

Line:82, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfIteratorManager.java -> Can you rename field variables as fSomething

Line:166, lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/ctfadaptor/CtfIteratorManager.java -> Maybe no need to swap positions if you just replace with the new context

-------------------------------------
